Conversation
jwag956
commented
Jun 16, 2026
Collaborator
- Change all the SECURITY_XX_WITHIN from the internal <#>, (e.g. 2 days) to timedelta.
- As part of flask-security init - accept the old style and convert to timedelta and issue a deprecation warning.
- add a utility to convert a timedelta to a string - this is pretty lame - the intent is for most applications to use humanize - which we'll integrate in another PR. This will solve the localization issue (Translation of %(within)s #1153)
- Pass the string - within - into the change_email_instructions template.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1241 +/- ##
=======================================
Coverage 98.65% 98.66%
=======================================
Files 43 43
Lines 5364 5377 +13
=======================================
+ Hits 5292 5305 +13
Misses 72 72 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Change all the SECURITY_XX_WITHIN from the internal <#>,<period> (e.g. 2 days) to timedelta. - As part of flask-security init - accept the old style and convert to timedelta and issue a deprecation warning. - add a utility to convert a timedelta to a string - this is pretty lame - the intent is for most applications to use humanize - which we'll integrate in another PR. This will solve the localization issue (#1153) - Pass the string - within - into the change_email_instructions template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.