Draft
Conversation
alxmrs
approved these changes
Aug 29, 2022
| ] | ||
| if len(dims) != 1: | ||
| raise KeyError(r"Could not valid combine_dim for indexer {idx_key}") | ||
| raise KeyError(f"Could not valid combine_dim for dimension {dimension}") |
Member
There was a problem hiding this comment.
My personal preference is {dimension!r}.
| assert concat_dim_val.stop == concat_dim_val.start + dimsize | ||
| region_slice.append(slice(concat_dim_val.start, concat_dim_val.stop)) | ||
| position = index[concat_dimension] | ||
| assert position.indexed |
Member
There was a problem hiding this comment.
Would be useful to have an assert message, maybe with some message to help end-users debug.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an internal refactor of the core
Indexdatatype. Like xarray-beamKeywe use something that looks like a dictionary to keep track of where a fragment lies within a dataset.This PR does a few things:
Indexto a standalonetypesmoduleIndexto use a key value pair ofDimensionandPositionPosition, moving closer to xarray-beam's "offests" concept.We may be able to eventually just use the same type of index as xarray-beam. In the meantime, this simplifies things and moves us in that direction.
My main complaint is that this feels a very java-like.
cc @shoyer and @alxmrs if you want to take a look.