[SITE-5793] Fix script injection in Behat test workflow#552
Open
AnaisPantheor wants to merge 2 commits into
Open
[SITE-5793] Fix script injection in Behat test workflow#552AnaisPantheor wants to merge 2 commits into
AnaisPantheor wants to merge 2 commits into
Conversation
Up to standards ✅🟢 Issues
|
jazzsequence
left a comment
Contributor
There was a problem hiding this comment.
Is this even needed? GHA environments naturally have a GH_TOKEN environment variable. This would only be needed if the token needs to be a PAT belonging to an actual individual/GH account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${{ secrets.GITHUB_TOKEN }}fromrun:block toenv:block in test-behat.ymlWhy
Using
${{ }}expressions directly insiderun:blocks is a script injection vulnerability. Secrets interpolated into shell scripts can leak through error messages or shell tracing. The secure pattern is to pass them throughenv:blocks.Test plan