feat(agent-templates): add codebase-check-before-blocking rule to base templates - #11083
Open
trac3r726 wants to merge 1 commit into
Open
Conversation
Before declaring a blocker for missing functionality or credentials, agents must search the project repo via gh CLI or GitHub MCP first. Many features already exist in code -- a blocker without a codebase check is incorrect and wastes cycles. The rule is added to: - server/src/onboarding-assets/default/AGENTS.md (base onboarding template) - skills/paperclip-create-agent/references/agents/coder.md - skills/paperclip-create-agent/references/agents/qa.md - skills/paperclip-create-agent/references/agents/securityengineer.md - skills/paperclip-create-agent/references/agents/uxdesigner.md - skills/paperclip-create-agent/references/baseline-role-guide.md Evidence: SSC-1468 -- C5 Delivery Lead declared blocked on missing Stampli access. Feature was already fully built in smst_client.py, migrations 115+123, runbook, and tests. Agent never checked. Tracked in SSC-2301.
trac3r726
requested review from
cryppadotta,
devinfoley and
nickyleach
as code owners
August 8, 2026 03:16
|
Hey @trac3r726! Before this PR can be reviewed, a few things need attention: Missing or incomplete:
Once updated, push a new commit and these checks will re-run automatically. — commitperclip |
Contributor
Greptile SummaryAdds a mandatory project-codebase search before agents declare blockers for missing functionality or credentials.
Confidence Score: 4/5The template changes appear safe to merge, but the PR description should first be completed with the repository-required planning, verification, risks, and model details. The changed Markdown consistently adds the intended blocker-prevention policy and does not alter runtime behavior; the remaining concern is the incomplete PR description.
|
| Filename | Overview |
|---|---|
| server/src/onboarding-assets/default/AGENTS.md | Adds the blocker-prevention rule to the default onboarding instructions without changing runtime code. |
| skills/paperclip-create-agent/references/agents/coder.md | Adds the full codebase-check policy to the Coder template. |
| skills/paperclip-create-agent/references/agents/qa.md | Adds the full codebase-check policy to the QA template. |
| skills/paperclip-create-agent/references/agents/securityengineer.md | Adds a semantically equivalent concise form of the policy to the Security Engineer template. |
| skills/paperclip-create-agent/references/agents/uxdesigner.md | Adds a semantically equivalent concise form of the policy to the UX Designer template. |
| skills/paperclip-create-agent/references/baseline-role-guide.md | Requires fallback roles capable of declaring blockers to include the new policy verbatim. |
Prompt To Fix All With AI
### Issue 1
server/src/onboarding-assets/default/AGENTS.md:11
**Complete the required PR description**
The description omits the required Thinking Path, Verification, Risks, Model Used, and Checklist sections, so reviewers cannot assess how the template change was verified or which risks were considered. Please update the description to follow the PR template and include these details.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "feat(agent-templates): add codebase-chec..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| - When your work produces a user-inspectable deliverable file, follow the Paperclip skill's "Generated Artifacts and Work Products" workflow before final disposition. Use `skills/paperclip/scripts/paperclip-upload-artifact.sh` when working in this repo, create/update an artifact work product when the file is the deliverable, and link the uploaded attachment in the final comment. Do not rely on local filesystem paths as the only access path. If an important file intentionally remains workspace-only, create/update a work product with `metadata.resourceRef.kind: "workspace_file"` and a workspace-relative path, then name that work product and path in the final comment. Treat browse/search as a fallback for recovering workspace files, not the preferred deliverable path. | ||
| - When your work produces or updates an operator-facing engineering output, create/update the matching work product: `pull_request` for opened PRs, `preview_url` for published previews, `runtime_service` for managed preview/dev services, `commit` for notable pushed commits, and `branch` when the branch itself is the handoff. A comment is not a substitute for the work product access path. | ||
| - Comments, documents, screenshots, work products, and `Remaining` bullets are evidence, not valid liveness paths by themselves. | ||
| - **Before declaring a blocker for missing functionality or credentials: check the project codebase first.** Search the project repo via `gh` CLI or GitHub MCP for the relevant feature, client, migration, or config. Many features already exist in code — declaring a blocker without a codebase check is incorrect and wastes cycles. Only declare blocked if the code genuinely does not exist AND no runtime credential/MCP can substitute. |
Contributor
There was a problem hiding this comment.
The description omits the required Thinking Path, Verification, Risks, Model Used, and Checklist sections, so reviewers cannot assess how the template change was verified or which risks were considered. Please update the description to follow the PR template and include these details.
Context Used: CONTRIBUTING.md has a guide for a good PR message ... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: server/src/onboarding-assets/default/AGENTS.md
Line: 11
Comment:
**Complete the required PR description**
The description omits the required Thinking Path, Verification, Risks, Model Used, and Checklist sections, so reviewers cannot assess how the template change was verified or which risks were considered. Please update the description to follow the PR template and include these details.
**Context Used:** CONTRIBUTING.md has a guide for a good PR message ... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the codebase-check-before-blocking rule to the base agent template and all role templates.
Root cause evidence (SSC-1468): C5 Delivery Lead declared blocked due to missing Stampli/SN access. The feature was already fully built in
smst_client.py, migrations 115+123, runbook, and tests. The agent never checked GitHub before blocking.Rule added (verbatim in templates)
Files changed
server/src/onboarding-assets/default/AGENTS.md— base onboarding template every new agent starts fromskills/paperclip-create-agent/references/agents/coder.md— Coder role templateskills/paperclip-create-agent/references/agents/qa.md— QA role templateskills/paperclip-create-agent/references/agents/securityengineer.md— SecurityEngineer role templateskills/paperclip-create-agent/references/agents/uxdesigner.md— UXDesigner role templateskills/paperclip-create-agent/references/baseline-role-guide.md— fallback guide for new role creationBlast radius
Templates only. No live agent AGENTS.md files are modified. New agents hired from these templates will inherit the rule automatically. Existing agents already have their own AGENTS.md and are not changed by this PR (fleet-wide rollout is a separate decision requiring board approval per Hermes agent ops mandate).
Closes SSC-2301.