Add CONTRIBUTING.md guide

[aaaaron]

Summary

• Adds a CONTRIBUTING.md with clear guidance for new contributors
• Two paths: small focused fixes (fast merge) vs larger changes (discuss in Discord first)
• General rules for commit messages, PR hygiene, and testing

🤖 Generated with Claude Code

[cryppadotta]

did you mean to put the onboarding wizard changes in this commit

[aaaaron]

Nope, and was already fixing it

[greptile-apps]

Greptile Summary

This PR adds a CONTRIBUTING.md guide outlining two contribution paths for new contributors, and bundles an unrelated fix to the OnboardingWizard adapter-selection click handler.

Key changes:

• CONTRIBUTING.md – new file with clear contribution guidelines, two contribution paths (small focused fixes vs. larger Discord-discussed changes), and general PR hygiene rules.
• OnboardingWizard.tsx – click handler for adapter-type selection is refactored:
  • Adds an early-return guard when the same adapter type is re-clicked (if (nextType === adapterType) return).
  • Rewrites two separate if blocks into a single if / else if / else chain — this fixes a subtle React state-batching bug in the original code where setModel("") (at the bottom) always ran last and silently overrode the setModel(DEFAULT_CODEX_LOCAL_MODEL) / setModel(DEFAULT_CURSOR_LOCAL_MODEL) calls above it.
  • Removes the && !model guards, so the default model is now always applied whenever the user switches to codex_local or cursor — a behavioral change that may affect users who had previously entered a custom model string.

Notable concern: the PR inadvertently violates the "One PR = one logical change" rule it introduces in CONTRIBUTING.md, as the documentation and the OnboardingWizard fix are unrelated.

Confidence Score: 4/5

• Safe to merge with minor caveats — the OnboardingWizard logic fix is an improvement, but the unconditional model reset on adapter switch is a deliberate UX change that should be confirmed.
• The CONTRIBUTING.md is pure documentation with no risk. The OnboardingWizard change fixes a real state-batching bug and is logically sound, but removes the !model guard, which changes visible UX behavior (model always resets to default on adapter switch). No tests appear to cover this component's click logic, so the change can't be automatically verified. Otherwise the change is small and well-scoped.
• ui/src/components/OnboardingWizard.tsx — confirm the intentional UX change of always resetting the model on adapter switch.

Important Files Changed

Filename	Overview
CONTRIBUTING.md	New documentation file outlining two contribution paths (small fixes vs. larger changes), general commit/PR hygiene rules, and a Discord contact pointer. Content is clear and low-risk.
ui/src/components/OnboardingWizard.tsx	Refactors the adapter-type selection click handler: adds an early-return guard for same-type re-clicks, rewrites separate if-blocks into a single if-else chain (fixing a state-batching bug where setModel("") always ran last), and removes && !model guards — meaning the default model is now always applied on every adapter switch, which is a behavioral change worth confirming.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A([User clicks adapter option]) --> B{opt.comingSoon?}
    B -- Yes --> Z([return — no-op])
    B -- No --> C{nextType === adapterType?}
    C -- Yes --> Z
    C -- No --> D[setAdapterType nextType]
    D --> E{Which adapter type?}
    E -- codex_local --> F[setModel DEFAULT_CODEX_LOCAL_MODEL]
    E -- cursor --> G[setModel DEFAULT_CURSOR_LOCAL_MODEL]
    E -- opencode_local --> H{model includes '/'}
    H -- Yes --> I([keep existing model])
    H -- No --> J[setModel empty string]
    E -- anything else --> K[setModel empty string]

Loading

Comments Outside Diff (1)

1. ui/src/components/OnboardingWizard.tsx, line 707-723 (link)

   Model reset on every adapter switch

   The old code guarded setModel(DEFAULT_CODEX_LOCAL_MODEL) and setModel(DEFAULT_CURSOR_LOCAL_MODEL) with && !model, hinting the intent was to preserve a user's previously entered model when they switch back to a familiar adapter type. With the !model check removed, every switch to codex_local or cursor now unconditionally resets the model to the hard-coded default.

   In practice this means: a user who picks codex_local, types in a custom model string, navigates to a different adapter to compare options, then returns to codex_local will silently lose their custom entry — it is always overwritten with DEFAULT_CODEX_LOCAL_MODEL.

   (The early-return guard if (nextType === adapterType) return prevents the reset when clicking the same option twice, but it does nothing when the user switches away and back.)

   If the intent is to always start fresh with the default when the adapter changes, that is reasonable UX — but it is worth confirming this is deliberate, since it is a visible behavior change for returning users.

_{Last reviewed commit: 049f768}

[greptile-apps]

PR itself violates the rule it introduces

This PR's own CONTRIBUTING.md says "One PR = one logical change", yet this same PR bundles two unrelated changes: adding the CONTRIBUTING.md guide and fixing the OnboardingWizard.tsx model-reset logic. While neither change is large, they are completely unrelated and would ideally be separate PRs (or at least the description should acknowledge the grouping).