fix(ui): make the mobile settings popover a full-screen sheet with a pinned Save & Apply so the action is always reachable#13
Merged
Conversation
…pinned Save & Apply so the action is always reachable
BigTava
requested review from
Cyr06130,
KarimJedda,
ba1uev,
justraman,
leonardocustodio and
tallesborges
as code owners
Contributor
Bundle Size ReportChunks over 500 KB:
All files
Commit: 3af1250 |
Contributor
|
❌ E2E Product suite failed on Failed tests:
Logs: https://github.com/paritytech/dotli-community/actions/runs/27466665704 |
Contributor
⚡ Performance ReportCold StartPhase breakdown
Warm StartPhase breakdown
Lukewarm Start (different site, same session)Overall: 🔴 regressed | p50: 7.59s → 9.26s (+22.0%) | p95: 8.81s → 11.84s (+34.3%) | Mann-Whitney: z=3.13 ✅ significant Phase breakdown
Commit: 3af1250 | Outliers (>2x best) discarded before stats |
leonardocustodio
approved these changes
Jun 14, 2026
leonardocustodio
left a comment
leonardocustodio
left a comment
Member
There was a problem hiding this comment.
nice, looks great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/paritytech/misc-issues/issues/146