fix(ci): resolve failing CI jobs#31
Merged
Merged
Conversation
lrubasze
requested review from
BigTava,
Cyr06130,
KarimJedda,
ba1uev,
justraman,
leonardocustodio and
tallesborges
as code owners
Contributor
Bundle Size ReportChunks over 500 KB:
All files
Commit: 3f837f1 |
Contributor
⚡ Performance Report
|
lrubasze
changed the title
bun audit flagged esbuild >=0.17.0 <0.28.1 (GHSA-gv7w-rqvm-qjhr high, GHSA-g7r4-m6w7-qqqr low), pulled in transitively via vite and polkadot-api. Pin the patched release through the existing overrides block. Build passes across all workspaces.
The setup-playwright action ran 'bunx playwright install' from the repo root, where playwright is not resolvable, so bunx fetched the latest (1.61.0) and installed browser build 1228. The Functional/E2E jobs run 'playwright test' from apps/host with the lockfile-pinned 1.60.0, which needs build 1223 — so every test failed at chromium.launch() with "Executable doesn't exist". Run the install from apps/host so bunx resolves the same pinned version and installs the matching build.
lrubasze
force-pushed
the
lrubasze/fix-esbuild-audit
branch
from
047a4aa to
590e58f
Compare
Contributor
|
This is a Nova-side outage and not a dot.li test failure. Re-run Logs: https://github.com/paritytech/dotli-community/actions/runs/27581073672 |
lrubasze
changed the title
The Functional/E2E Build steps ran 'turbo run build' with no env, so the host shell was built without VITE_NETWORKS. packages/config/src/network.ts throws on boot when it's unset, leaving the shell stuck before it mounts the protocol/app iframes — every test then timed out waiting for the sandbox iframe. deploy.yml already supplies this from repo vars; give the test build its own value (paseo-next-v2 first to match the E2E signer bot's network).
lrubasze
changed the title
Contributor
|
❌ E2E Product suite failed on Failed tests:
Logs: https://github.com/paritytech/dotli-community/actions/runs/27582324560 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing CI jobs:
Pin
esbuild: ^0.28.1viaoverridesto clear the advisory (high RCE + low file-read).Run
playwright installfromapps/hostso the installed browser matches the pinned version (was run from repo root → fetched latest → wrong build, tests died atchromium.launch()).Set
VITE_NETWORKSon the testBuildsteps; without it the host shell throws on boot and never mounts the protocol/app iframes, so every test timed out.