fix(e2e): co-locate traces with results.json so CI uploads them#32
Merged
Conversation
Playwright's default outputDir is packageJsonDir/test-results (apps/host/test-results), but the JSON reporter writes results.json relative to the config dir (apps/host/tests/e2e/test-results). The CI "Upload test results" step uploads only the latter, so trace.zip was never captured and E2E failures couldn't be diagnosed. Set an explicit outputDir relative to the config dir so traces land alongside results.json — the dir CI already uploads and reads.
lrubasze
requested review from
BigTava,
Cyr06130,
KarimJedda,
ba1uev,
justraman,
leonardocustodio and
tallesborges
as code owners
Contributor
⚡ Performance Report
|
Contributor
Bundle Size ReportChunks over 500 KB:
All files
Commit: f840e5b |
Contributor
|
This is a Nova-side outage and not a dot.li test failure. Re-run Logs: https://github.com/paritytech/dotli-community/actions/runs/27601349936 |
BigTava
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes E2E trace upload so CI failures are diagnosable.
Playwright's default
outputDir(traces) isapps/host/test-results/, but the JSON reporter writesresults.jsontoapps/host/tests/e2e/test-results/. CI uploads only the latter, sotrace.zipwas never captured.Sets an explicit
outputDirrelative to the config dir so traces land alongsideresults.json— the dir the upload andExtract failed testssteps already use.First step toward greening the E2E Product suite; the actual per-op root-cause needs a re-run (signer bot up) to capture a trace.