[pallet-assets] Reject delegatecall into pallet-assets ERC20 precompile#11676
Draft
[pallet-assets] Reject delegatecall into pallet-assets ERC20 precompile#11676
Conversation
0xRVE
added
T7-smart_contracts
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump minor |
…time_dev --bump minor'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no legitimate use case for delegatecalling into the asset precompile. This matches the precedent set by the Storage precompile, which already enforces a delegatecall check (in the opposite direction — it requires delegatecall).
Changes
lib.rs: AddERR_DELEGATECALL_DENIEDconst andis_delegate_call()guard before any dispatch logictests.rs: Adddelegatecall_is_rejectedtest using theCaller.solfixtureTest plan
cargo test -p pallet-assets-precompiles— all 67 tests passdelegatecall_is_rejectedverifies the guard rejects delegatecall via theCallerfixture contract