Logging improvements for the collator revamp#12282
Open
tdimitrov wants to merge 3 commits into
Open
Conversation
…ntal: - Decrease log levels in `wait_for_first_leaf` to DEBUG, to avoid startup spam - Use `warn_if_frequent` for fetch errors - Log assignment changes on view change - pick_best_advertisement: trace logs for each outcome - update_view: log scheduling parent <-> assigned core mapping - update_view: log sp removal - handle_seconded_collation: logs for each error case - PeerManager: log reputation updates
tdimitrov
added
T8-polkadot
Contributor
Author
|
/cmd prdoc --audience node_dev --bump patch |
…e_dev --bump patch'
sandreim
approved these changes
Jun 6, 2026
sandreim
left a comment
sandreim
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but not sure about the INFO level additions.
|
|
||
| let scheduled_paras = collation_manager.assignments(); | ||
|
|
||
| gum::info!( |
Contributor
There was a problem hiding this comment.
Why is this important to be logged at info level ?
Contributor
Author
There was a problem hiding this comment.
Ok, let's downgrade this to debug too.
My initial idea was to have information about assignments on INFO level, but it will be too noisy.
| ); | ||
|
|
||
| if old_assignments != new_assignments { | ||
| gum::info!( |
Contributor
Author
There was a problem hiding this comment.
You are right, this is not a good idea.
groupRotation is 10 on polkadot, so we'll have this log ~each minute, which is not worth it. I'll downgrade it to debug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some logging updates:
wait_for_first_leafto DEBUG, to avoid startup spamwarn_if_frequentfor fetch errorsPartially addresses #10402