Auto-generate the GetWeight impl for the XCM Instruction enum#12298
Draft
bolajahmad wants to merge 6 commits into
Draft
Auto-generate the GetWeight impl for the XCM Instruction enum#12298bolajahmad wants to merge 6 commits into
bolajahmad wants to merge 6 commits into
Conversation
…macro and deleted manual wite in v5
…include mock definitions for Instructions (useful for testing); add test to ensure proper code generation
…e derive_weight_oinfo_derive to also compose weight_class data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #12279.
Define a custom macro to autogenerate WeightInfo implementations for Instruction.
Integration
No special integration is needed. While the
XcmWeightInfois used by runtimes of rococo/westend/cumulus, this PR is unexpected to break these implementations as this is an optimization and refactoring issue.Review Notes
This PR deleted a manual code block and uses the same
xcm_procedural::XcmWeightInfoTraitthat generates the WeightInfo trait to also generate the implementations also. In future updates, nothing else needs to be done as every new Instruction will be autogenerated.This implementation includes a unit test to prevent regression logic when using the XcmWeightInfo.
Include your leftover TODOs, if any, here.
Checklist
Trequired)/cmd label <label-name>to add labels