approval-voting: cleanup coalescing logic#12314
Open
alexggh wants to merge 7 commits into
Open
Conversation
refactor approval coalescing logic to get the runtime value through ExtendedSessionInfo. Changes are fully backwards compatible with the existing logic, tested 50-50% split of old nodes and new nodes and new nodes with old runtime and new runtime with old nodes. Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
eskimor
approved these changes
Jun 9, 2026
eskimor
left a comment
eskimor
left a comment
Member
There was a problem hiding this comment.
Looks good! Thank you!
Only left a few nits.
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
alexggh
added
the
T8-polkadot
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
alexggh
added
A4-backport-stable2603
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor approval coalescing logic to get the runtime value through ExtendedSessionInfo.
Changes are fully backwards compatible with the existing logic, tested 50-50% split of old nodes and new nodes and new nodes with old runtime and new runtime with old nodes.