statement-store: build local affinity from a configured source#12316
Open
AndreiEres wants to merge 6 commits into
Open
statement-store: build local affinity from a configured source#12316AndreiEres wants to merge 6 commits into
AndreiEres wants to merge 6 commits into
Conversation
…xplicit-affinity-configured-source # Conflicts: # substrate/client/network/statement/src/v2dht/explicit_affinity.rs
| #[arg( | ||
| long = "statement-affinity-topic", | ||
| value_name = "TOPIC", | ||
| num_args = 1.., |
Contributor
There was a problem hiding this comment.
Does the combination of 1.. here and Vec<_> (instead of Option<Vec<_>>) allow not specifying the argument at all? 🤔
Contributor
Author
There was a problem hiding this comment.
Not necessary here, removed. IIUC we receive an empty vec if nothing was provided
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
P1sar
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #11934. Plumb a --statement-affinity-topic CLI flag into ExplicitAffinity as the Configured source. Topics parse through a new impl FromStr for Topic.