Improve performance - #122
Open
gharlan wants to merge 1 commit into
Open
Conversation
gharlan
commented
Jul 6, 2025
| { | ||
| $this->alphabet = $alphabet; | ||
| $this->alphabetLength = count($alphabet); | ||
| $this->alphabetLength = BigInteger::of(count($alphabet)); |
Contributor
Author
There was a problem hiding this comment.
brick/math converts this value in all operations into BigInteger objects. Now we are doing it here once, so it does not have to be converted again and again.
| $previousNumber = clone $number; | ||
| $number = $number->dividedBy($this->alphabetLength, RoundingMode::DOWN); | ||
| $digit = $previousNumber->mod($this->alphabetLength); | ||
| [$number, $digit] = $number->quotientAndRemainder($this->alphabetLength); |
Contributor
Author
There was a problem hiding this comment.
.. but this has the bigger impact on the performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShortUuid::encodecan be called quite often when having many urls on a page.On a random page in my project this pr gives this improvement (measured via blackfire):