Skip to content

complete tests - #13

Open
peter279k wants to merge 2 commits into
pascaldevink:masterfrom
peter279k:completed_tests
Open

complete tests#13
peter279k wants to merge 2 commits into
pascaldevink:masterfrom
peter279k:completed_tests

Conversation

@peter279k

Copy link
Copy Markdown

Changed log

  • change the higher PHPUnit version because it fixes the count function problem for PHP version 7.2.
    This is the Travis build log before updating the PHPUnit version.
    And here is the new Travis build log after using the PHPUnit version 6.5+.
  • integrate the code coverage service coveralls for this package.
    Here is the code coverage report generated by coveralls.
  • add more tests.

Comment thread .editorconfig
# This file is for unifying the coding style for different editors and IDEs
# editorconfig.org

root = true

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this file please? Or even better, add it to the .gitignore file?
Although this is nice of course, it is very specific for a (set of) editors, whilst ignoring others. Next to that, I'd much rather have these rules enforced with something like grumphp and php-cf-fixer, so it doesn't matter which editor people use.

@peter279k peter279k Feb 2, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. It can use the php-cs-fixer or StyleCI and let the command be the Composer script in composer.json.
Would you prefer which one to replace the .editorconfig?

Thanks.

@pascaldevink

Copy link
Copy Markdown
Owner

Thanks for the test additions, good spot with the phpunit upgrade.
I don't personally care much for coverage numbers, which is why I never added coveralls before, but now that you've implemented it I won't hold it back.

@peter279k

peter279k commented Feb 2, 2018

Copy link
Copy Markdown
Author

Yes. The coverage numbers for someone that it's not the preference.
I integrate this because I think it's just a reference that let someone know the coverage numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants