Add dataworth plugin#43
Open
dbrakenhoff wants to merge 10 commits into
Open
Conversation
dbrakenhoff
commented
Apr 22, 2026
dbrakenhoff
commented
Member
- add DataWorth class as entry point to computations
- add example notebook with explanation (to the best of my current ability)
- add docs
- add dummy test (to be expanded later)
- add dependencies to pyproject.toml
- add DataWorth class as entry point to computations - add example notebook with explanation (to the best of my current ability) - add docs - add dummy test (to be expanded later) - add dependencies to pyproject.toml
martinvonk
reviewed
Apr 29, 2026
martinvonk
approved these changes
Apr 30, 2026
Contributor
There was a problem hiding this comment.
maybe nice to let copilot create some tests
Member
Author
There was a problem hiding this comment.
copilot is MIA at the moment ;)
| var_params_k = np.diag(C_k) | ||
| return logdet_k, var_params_k | ||
|
|
||
| def data_worth_per_observation(self): |
Contributor
There was a problem hiding this comment.
I cant comment per line in the notebook. But it is maybe nice to have an keyword argument option to compute data_worth_per_observation as a percentage, just as in the notebook... And is the unit then not in percentage point instead of a percentage?
Member
Author
There was a problem hiding this comment.
Agreed, this would be a nice option to have.
| class DataWorth: | ||
| def __init__(self, ml, J=None, objfun_target="noise"): | ||
|
|
||
| self.ml = ml |
Contributor
There was a problem hiding this comment.
may be better to copy the model?
Member
Author
There was a problem hiding this comment.
The model is never modified in any meaningful way, so I don't think it matters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.