Spec: Define per-context contribution limits by dmcardle · Pull Request #164 · patcg-individual-drafts/private-aggregation-api

dmcardle · 2024-10-16T17:11:52Z

This change adds the web-visible maxContributions field, which enables some callers to request different numbers of contributions per report.

Per-context limits are being added to the explainer in #146.

Preview | Diff

alexmturner

Thanks, Dan! Looks good -- just some nits

alexmturner · 2024-11-04T21:55:26Z

 modified to add a new field:
 <xmp class="idl">
-dictionary ProtectedAudiencePrivateAggregationConfig {
+dictionary ProtectedAudienceAuctionPrivateAggregationConfig {


Need to rebase this PR after #166. Although as a general point -- wondering if we should make this change at the same time as we add contextId and filteringIdMaxBytes given they all require activating deterministic counts.

That being said, we'll probably want to make the Shared Storage spec changes soon

Thanks for the heads up.

I'm planning to make the Protected Audience and Shared Storage spec PRs tomorrow. Let's merge those before this PR.

I'm rebasing now, so I'll have to delete this hunk of the diff. This is the relevant part for the Protected Audience PR:

@@ -1341,16 +1377,21 @@ WebIDL modifications {#protected-audience-api-webidl-modifications} The {{AuctionAdConfig}} and {{AuctionAdInterestGroup}} dictionaries are modified to add a new field: <xmp class="idl"> -dictionary ProtectedAudiencePrivateAggregationConfig { +dictionary ProtectedAudienceAuctionPrivateAggregationConfig { + USVString aggregationCoordinatorOrigin; + [EnforceRange] unsigned long long maxContributions; +}; + +dictionary ProtectedAudienceInterestGroupPrivateAggregationConfig { USVString aggregationCoordinatorOrigin; }; partial dictionary AuctionAdConfig { - ProtectedAudiencePrivateAggregationConfig privateAggregationConfig; + ProtectedAudienceAuctionPrivateAggregationConfig privateAggregationConfig; }; partial dictionary AuctionAdInterestGroup { - ProtectedAudiencePrivateAggregationConfig privateAggregationConfig; + ProtectedAudienceInterestGroupPrivateAggregationConfig privateAggregationConfig; }; </xmp>

Just uploaded a rough draft of the Protected Audience spec change in WICG/turtledove#1378.

And here's the Shared Storage spec change: WICG/shared-storage#216.

dmcardle · 2025-01-07T22:29:12Z

+Issue: Shouldn't the paragraph above refer to fields of [=pre-specified report
+ parameters=] instead of [=aggregatable report=]?


@alexmturner WDYT?

Yeah, switching over sgtm. (I think this was written before pre-specified report parameters existed.)

alexmturner · 2025-01-08T04:14:37Z

-    report is sent, even if there are no contributions or there is insufficent
-    budget for the requested contributions. See [Protecting against leaks via
-    the number of reports](#protecting-against-leaks-via-the-number-of-reports).
+Note: Even when budget is insufficient for the requested contributions, a report


Should we include the "no contributions requested" case in this note?

Sure. I'll give this another pass -- let me know if you preferred the original.

alexmturner · 2025-01-08T04:17:21Z

+Issue: Shouldn't the paragraph above refer to fields of [=pre-specified report
+ parameters=] instead of [=aggregatable report=]?


Yeah, switching over sgtm. (I think this was written before pre-specified report parameters existed.)

Explainer: patcg-individual-drafts/private-aggregation-api#146 Spec change: patcg-individual-drafts/private-aggregation-api#164

The goal is to enable Shared Storage embedders to override the default number of contributions per Private Aggregation report. To that end, this change adds the `maxContributions` field to the web-visible Private Aggregation config dictionary and plumbs its value into Private Aggregation's "pre-specified report parameters". Context: * Explainer: patcg-individual-drafts/private-aggregation-api#146 * Spec change: patcg-individual-drafts/private-aggregation-api#164

alexmturner

Thanks, LGTM!

alexmturner · 2025-01-15T17:10:18Z

Not sure what's going on with the validate spec check. I wonder if we need to update something? Will take another look.

dmcardle · 2025-01-15T17:16:22Z

Great, I'll squash and push again, let's see if the validation still fails.

dmcardle · 2025-01-15T17:28:51Z

Still failing. Amusingly, the "Validate Web IDL" step from pythagoraskitty/w3c-spec-prod@v1.2 fails with a Chrome stacktrace...

  Failed to launch the browser process!
  [0115/172657.690711:FATAL:zygote_host_impl_linux.cc(117)] No usable sandbox! Update your kernel or see https://chromium.googlesource.com/chromium/src/+/main/docs/linux/suid_sandbox_development.md for more information on developing with the SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox.
  #0 0x557a80362f49 base::debug::CollectStackTrace()
  #1 0x557a802cc933 base::debug::StackTrace::StackTrace()
  #2 0x557a802e0500 logging::LogMessage::~LogMessage()
  #3 0x557a7e4e213b content::ZygoteHostImpl::Init()
  #4 0x557a7fe7cb9f content::ContentMainRunnerImpl::Initialize()
  #5 0x557a7fe7afa5 content::RunContentProcess()
  #6 0x557a7fe7b0cd content::ContentMain()
  #7 0x557a7fed9fd9 headless::HeadlessBrowserMain()
  #8 0x557a7fed9cf8 headless::HeadlessShellMain()
  #9 0x557a7ccedae1 ChromeMain
  #10 0x7f905e62a1ca (/usr/lib/x86_64-linux-gnu/libc.so.6+0x2a1c9)
  #11 0x7f905e62a28b __libc_start_main
  #12 0x557a7cced92a _start

alexmturner · 2025-01-15T17:29:46Z

Just landed a change to the yaml to use w3c/spec-prod@v2, so maybe one more rebase might fix it? (or at least cause a different error)

This change adds the web-visible `maxContributions` field, which enables some callers to request different numbers of contributions per report.

alexmturner · 2025-01-15T18:01:38Z

yay, it passed -- thanks!

SHA: 3433a3e Reason: push, by alexmturner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

The goal is to enable Shared Storage embedders to override the default number of contributions per Private Aggregation report. To that end, this change adds the `maxContributions` field to the web-visible Private Aggregation config dictionary and plumbs its value into Private Aggregation's "pre-specified report parameters". Context: * Explainer: patcg-individual-drafts/private-aggregation-api#146 * Spec change: patcg-individual-drafts/private-aggregation-api#164

dmcardle commented Oct 18, 2024

View reviewed changes

Comment thread spec.bs Outdated

dmcardle marked this pull request as ready for review November 4, 2024 14:54

alexmturner reviewed Nov 4, 2024

View reviewed changes

dmcardle force-pushed the dmcardle-per-call-report-sizing-spec branch from 1df696c to ff6bee4 Compare January 7, 2025 22:07

dmcardle commented Jan 7, 2025

View reviewed changes

alexmturner reviewed Jan 8, 2025

View reviewed changes

dmcardle mentioned this pull request Jan 8, 2025

Spec: add glue for Private Aggregation's per-context contribution limits WICG/turtledove#1378

Draft

dmcardle mentioned this pull request Jan 9, 2025

[spec] Enable per-context contribution limits for Private Aggregation WICG/shared-storage#216

Merged

dmcardle commented Jan 9, 2025

View reviewed changes

Comment thread spec.bs Outdated

alexmturner approved these changes Jan 15, 2025

View reviewed changes

dmcardle force-pushed the dmcardle-per-call-report-sizing-spec branch from c96162a to 5aeb65c Compare January 15, 2025 17:17

Spec: Define per-context contribution limits

8472d3b

This change adds the web-visible `maxContributions` field, which enables some callers to request different numbers of contributions per report.

dmcardle force-pushed the dmcardle-per-call-report-sizing-spec branch from 5aeb65c to 8472d3b Compare January 15, 2025 17:58

alexmturner merged commit 3433a3e into patcg-individual-drafts:main Jan 15, 2025

github-actions Bot added a commit that referenced this pull request Jan 15, 2025

Spec: Define per-context contribution limits (#164)

4c6fc81

SHA: 3433a3e Reason: push, by alexmturner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

		Issue: Shouldn't the paragraph above refer to fields of [=pre-specified report
		parameters=] instead of [=aggregatable report=]?

Uh oh!

Conversation

dmcardle commented Oct 16, 2024 • edited by pr-preview Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

alexmturner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexmturner left a comment

Choose a reason for hiding this comment

Uh oh!

alexmturner commented Jan 15, 2025

Uh oh!

dmcardle commented Jan 15, 2025

Uh oh!

dmcardle commented Jan 15, 2025

Uh oh!

alexmturner commented Jan 15, 2025

Uh oh!

alexmturner commented Jan 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dmcardle commented Oct 16, 2024 •

edited by pr-preview Bot

Loading