Fix handling of temperature value 0#480
Merged
Merged
Conversation
Contributor
|
That's an elegant solution ;) |
patman15
deleted the
478-incorrect-filtering-of-temperature-values-at-0
branch
patman15
added a commit
to patman15/aiobmsble
that referenced
this pull request
Sep 8, 2025
patman15
added a commit
to patman15/aiobmsble
that referenced
this pull request
Sep 8, 2025
patman15
restored the
478-incorrect-filtering-of-temperature-values-at-0
branch
patman15
added a commit
that referenced
this pull request
Sep 12, 2025
* adapt naming - `AdvertisementPattern` to `MatcherPattern` - `reconnect` to `keep_alive` * remove dummy example * fix removal of 0 values in _temp_values() (#480) * Add Seplos `SP1??B*` pattern (#482) * Feature align aiobmsble (#481) * adapt naming - `AdvertisementPattern` to `MatcherPattern` - `reconnect` to `keep_alive` * remove dummy example * Add detection of LiTime 24V BMS type based on serial number (#484) * Fix operator precedence (#485) * fix removal of 0 values in _temp_values() * fix operator precedence * Support ANT BMS (legacy BLE protocol) (#468) * Support ANT BMS (legacy BLE protocol) * Refine frame parsing for ant_bms_legacy * Add basic testing for ant_bms_legacy * Rename plugin ant_bms_legacy to ant_legacy_bms to comply with component conventions * Fix ant_legacy_bms test coverage * Fix compliancy with bms_ble repository design * Add 'total_charge' value (#476) to results * Remove 'dead' code * Remove unused import * Fix temperature sensors count * Remove cell high/low voltage parsing and calc 'delta_voltage' from internal '_add_missing_values' * Remove local reference to self._data in member function body * Fix 'BaseBMS._temp_values' operator precedence * Fix imported symbol * Fix missing comma after manual merge * fix pylint issues * fix design_capacity / temp sensors * add typing * Update ant_legacy_bms.py * align constants * test to check design capacity provision * rename legacy bms * Update README.md --------- Co-authored-by: patman15 <14628713+patman15@users.noreply.github.com> * update to 1.21.0 --------- Co-authored-by: krahabb <13969600+krahabb@users.noreply.github.com>
patman15
added a commit
that referenced
this pull request
Sep 13, 2025
* migrate to aiobmsble * disable mypy * fix device discovery for aiobmsble * add test for v2 config entry not yet correct * complete test coverage * Update aiobmsble to 0.2.2 * disable fuzz tests * update for new retry-connector * update requirements * Update fuzzing.yaml * Update manifest.json * Update README.md * Feature align aiobmsble (#488) * adapt naming - `AdvertisementPattern` to `MatcherPattern` - `reconnect` to `keep_alive` * remove dummy example * fix removal of 0 values in _temp_values() (#480) * Add Seplos `SP1??B*` pattern (#482) * Feature align aiobmsble (#481) * adapt naming - `AdvertisementPattern` to `MatcherPattern` - `reconnect` to `keep_alive` * remove dummy example * Add detection of LiTime 24V BMS type based on serial number (#484) * Fix operator precedence (#485) * fix removal of 0 values in _temp_values() * fix operator precedence * Support ANT BMS (legacy BLE protocol) (#468) * Support ANT BMS (legacy BLE protocol) * Refine frame parsing for ant_bms_legacy * Add basic testing for ant_bms_legacy * Rename plugin ant_bms_legacy to ant_legacy_bms to comply with component conventions * Fix ant_legacy_bms test coverage * Fix compliancy with bms_ble repository design * Add 'total_charge' value (#476) to results * Remove 'dead' code * Remove unused import * Fix temperature sensors count * Remove cell high/low voltage parsing and calc 'delta_voltage' from internal '_add_missing_values' * Remove local reference to self._data in member function body * Fix 'BaseBMS._temp_values' operator precedence * Fix imported symbol * Fix missing comma after manual merge * fix pylint issues * fix design_capacity / temp sensors * add typing * Update ant_legacy_bms.py * align constants * test to check design capacity provision * rename legacy bms * Update README.md --------- Co-authored-by: patman15 <14628713+patman15@users.noreply.github.com> * update to 1.21.0 --------- Co-authored-by: krahabb <13969600+krahabb@users.noreply.github.com> * fix ant_leg_bms inclusion * Update CONTRIBUTING.md * Update README.md --------- Co-authored-by: krahabb <13969600+krahabb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.