Fix Scriban loop limit exceeded when rendering large HTML reports - #31
Open
polojs wants to merge 2 commits into
Open
Fix Scriban loop limit exceeded when rendering large HTML reports#31polojs wants to merge 2 commits into
polojs wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30
Report generation crashes on SBOMs with more than 1000 components/dependencies, since Template.Render(object) uses Scriban's default TemplateContext, which caps loops at 1000 iterations to guard against runaway templates.
Set LoopLimit = 0 (disabled) because Template.html is a fixed, trusted embedded resource we control, not user-supplied input, so that guard isn't needed here.