Skip to content

fixed peculiarity of storing floating numbers #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kat4ex wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed peculiarity of storing floating numbers #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const cheerio = require("cheerio")
const got = require("got")
const decimal = require("decimal.js")

// FIXME: round upto 2 decimal places
// TODO: Add doc for other functions
Expand Down Expand Up @@ -235,7 +236,7 @@ class CurrencyConverter {
throw new Error("currency amount should be a positive value")

return this.rates().then((rates) =>{
this.convertedValue = rates * this.currencyAmount
this.convertedValue = new decimal(rates).mul(this.currencyAmount)
return this.convertedValue
})
}
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"main": "index.js",
"dependencies": {
"cheerio": "latest",
"decimal.js": "latest",
"got": "latest"
},
"devDependencies": {
Expand Down