Skip to content

Feature/add devtools viewer link to sheets #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-benson-fc wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Feature/add devtools viewer link to sheets #131

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
163a514
reduce eslint warnings
paulirish Jun 23, 2017
e37b36e
Update readme (#126)
young Jun 29, 2017
095608e
ci: removing nodejs duplication
willmendesneto Jul 10, 2017
e489e92
ci: removing progress in install tasks
willmendesneto Jul 10, 2017
da99ff0
Adds timeline viewer link to sheet output if files uploaded to drive
david-benson-fc Jul 17, 2017
8262700
Merge remote-tracking branch 'upstream/master' into feature/add_devto…
david-benson-fc Jul 18, 2017
757b5c3
Correct file check in lib/sheets
david-benson-fc Jul 19, 2017
cddb412
Timeline viewer link: Check upload flag is true before adding link
david-benson-fc Jul 19, 2017
d770a4c
Merge remote-tracking branch 'origin/master' into feature/add_devtool…
Aug 4, 2017
a3bd4c7
Modifications in response to change requests [WIP]
Aug 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,10 @@ class PWMetrics {

if (this.flags.upload) {
const driveResponse = await upload(data, this.clientSecret);

preparedData.fileId = driveResponse.id;
preparedData.fileName = driveResponse.name;

this.view(driveResponse.id);
}

Expand Down
2 changes: 2 additions & 0 deletions lib/metrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ function prepareData(res: LighthouseResults): MetricsResults {
});

return {
fileId: '',
fileName: '',
timings,
timestamps,
generatedTime: res.generatedTime,
Expand Down
10 changes: 9 additions & 1 deletion lib/sheets/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const metricsIds = require('../metrics').ids;
const SHEET_TYPES = {
'GOOGLE_SHEETS': 'GOOGLE_SHEETS'
};
const VIEWER_URL_PREFIX = 'https://chromedevtools.github.io/timeline-viewer/?loadTimelineFromURL=drive://';

class Sheets {
constructor(public config: SheetsConfig, public clientSecret: AuthorizeCredentials) {
Expand Down Expand Up @@ -50,6 +51,12 @@ class Sheets {
results.forEach(data => {
const getTiming = (key: string) => data.timings.find(t => t.id === key).timing;
const dateObj = new Date(data.generatedTime);
let viewerUrl = '';

if(typeof data.fileName !== 'undefined' && typeof data.fileName !== 'undefined') {

@willmendesneto willmendesneto Jul 19, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if(data.fileName) {
  viewerUrl = VIEWER_URL_PREFIX + data.fileId;
}

@david-benson-fc david-benson-fc Jul 19, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh - just noticed one of those is supposed to be data.fileId, but that's the only one needed now - I originally intended to use both, but ditched the idea of using the file name as the link text.

I use typeof rather than a truthy check as it's won't choke on undefined.

@willmendesneto willmendesneto Jul 21, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you don't need to be concerned of that because undefined is false when type checked in a boolean scenario.

viewerUrl = VIEWER_URL_PREFIX + data.fileId;
}

// order matters
valuesToAppend.push([
data.lighthouseVersion,
Expand All @@ -62,7 +69,8 @@ class Sheets {
getTiming(metricsIds.VC100),
getTiming(metricsIds.TTFI),
getTiming(metricsIds.TTCI),
getTiming(metricsIds.VC85)
getTiming(metricsIds.VC85),
viewerUrl
]);
});

Expand Down
2 changes: 2 additions & 0 deletions types/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ interface FeatureFlags {
}

interface MetricsResults {
fileName: string,
fileId: string,
timestamps: Timestamp[];
timings: Timing[];
generatedTime: string;
Expand Down