Skip to content

fix: cleanup on salsa and chacha tag mismatch #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulmillr merged 3 commits into from
Apr 11, 2026
Merged

fix: cleanup on salsa and chacha tag mismatch #68

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98b8578
fix: cleanup on salsa tag mismatch
ChALkeR Apr 11, 2026
953887f
fixup: cleanup ciphPlaintext too
ChALkeR Apr 11, 2026
5316f58
fixup: also in chacha
ChALkeR Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/salsa.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,10 @@ export const xsalsa20poly1305: TRet<ARXCipher> = /* @__PURE__ */ wrapCipher(
clean(tmp);
const authKey = xsalsa20(key, nonce, tmp, tmp);
const tag = poly1305(ciphPlaintext, authKey);
if (!equalBytes(passedTag, tag)) throw new Error('invalid tag');
if (!equalBytes(passedTag, tag)) {
clean(tmp, passedTag, tag);
Comment thread
ChALkeR marked this conversation as resolved.
Outdated
throw new Error('invalid tag');
}
// output = stream ^ output[16..]
xsalsa20(key, nonce, output.subarray(16), output.subarray(16));
clean(tmp, passedTag, tag);
Expand Down
Loading