Add SCIANTIX fuel performance code#20
Open
partofthething wants to merge 2 commits intopaulromano:mainfrom
Open
Add SCIANTIX fuel performance code#20partofthething wants to merge 2 commits intopaulromano:mainfrom
partofthething wants to merge 2 commits intopaulromano:mainfrom
Conversation
Owner
|
URL doesn't seem to work for me. Does it for you? |
Contributor
Author
|
I had to make an account and log in to gitlab before it would even let me search the site! This blew my mind. But anyway as a logged in user the URL does work. In a private tab it does not. Gitlab has a strange stance on that I guess? Maybe I'll add a note, one sec. |
rzehumat
reviewed
Oct 10, 2024
Comment on lines
+81
to
+82
| - [SCIANTIX](https://gitlab.com/poliminrg/sciantix) — A fission gas release code for | ||
| oxide fuels (\*Gitlab account required to access) |
There was a problem hiding this comment.
Suggested change
| - [SCIANTIX](https://gitlab.com/poliminrg/sciantix) — A fission gas release code for | |
| oxide fuels (\*Gitlab account required to access) | |
| - [SCIANTIX](https://github.com/sciantix/sciantix-official) — A fission gas release code for nuclear fuels |
|
Hi @paulromano and @partofthething . I think they use GitHub repo now. Also, I think their goal is general code, not necessarily limited to oxidic fuel only (though I am unsure what is the current status of the supported fuel types). Could you please review my suggestion and merge this PR, if applicable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also: https://doi.org/10.1016/j.jnucmat.2020.152042