vcxproj: add support for Image and ResourceCompile includes#134
Open
bk138 wants to merge 1 commit intopavelliavonau:developfrom
Open
vcxproj: add support for Image and ResourceCompile includes#134bk138 wants to merge 1 commit intopavelliavonau:developfrom
bk138 wants to merge 1 commit intopavelliavonau:developfrom
Conversation
The parsing of entries like `<Image Include="image.bmp" />` is more of a UX thing as developers will expect image groups they have in their original Visual Studio project to appear in whatever IDE they're using with their converted-to-CMake-project. At least so I think. The parsing of entries like `<ResourceCompile Include="resource.rc" />` however makes resource file entries appear in the resulting CMakeLists.txt which is a real functionality fix. Without the resource files listed, converting projects using resource files would result in broken converted projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parsing of entries like
<Image Include="image.bmp" />is more ofa UX thing as developers will expect image groups they have in their
original Visual Studio project to appear in whatever IDE they're
using with their converted-to-CMake-project. At least so I think.
The parsing of entries like
<ResourceCompile Include="resource.rc" />however makes resource file entries appear in the resulting
CMakeLists.txt which is a real functionality fix. Without the resource
files listed, converting projects using resource files would result in
broken converted projects.