Updating to support most recent PDCursesMod#116
Conversation
…rk with current native PdCursesMod libraries
pavkam
left a comment
There was a problem hiding this comment.
Assuming this is correct as I've no way of testing this ATM. I don't remember if we have WinARM builds for this library but this might break those old versions (low interest there so not a problem for now)
There was a problem hiding this comment.
Pull Request Overview
This PR updates the native function reference for the endwin function to align with the most recent version of PDCursesMod, changing from version 4302 to 4400 naming convention.
Key Changes:
- Updates delegate name from
endwin_w32_4302toendwin_w32_4400in the function map - Updates corresponding function resolver call to use the new delegate name
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PdCursesMod32FunctionMap.cs | Updates delegate declaration to match PDCursesMod version 4400 |
| PdCursesMod32Backend.cs | Updates function resolver call to reference the new delegate name |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Build seems to fail for some reason |
|
That's embarrassing. I forgot to add the the necessary changes to the Tests project to use the new function name. Sorry about that. |
(Sorry to bother you with multiple pull requests. I've had a few queued up and this is my day off, so your getting a few at once.)
This is a simple change to the
endwin_*native function name inPdCursesMod32FunctionMap. This matches the current version of PDCursesMod and the one you are distributing via theSharpie-Libs-PdCursesModnuget package.(See https://github.com/Bill-Gray/PDCursesMod/blob/master/curses.h and commit Bill-Gray/PDCursesMod@78658c9 for the source of the change).