Skip to content

Updating to support most recent PDCursesMod#116

Merged
pavkam merged 4 commits into
pavkam:mainfrom
jordan-hemming:pdcursesmod-4400
Sep 26, 2025
Merged

Updating to support most recent PDCursesMod#116
pavkam merged 4 commits into
pavkam:mainfrom
jordan-hemming:pdcursesmod-4400

Conversation

@jordan-hemming

Copy link
Copy Markdown
Contributor

(Sorry to bother you with multiple pull requests. I've had a few queued up and this is my day off, so your getting a few at once.)

This is a simple change to the endwin_* native function name in PdCursesMod32FunctionMap. This matches the current version of PDCursesMod and the one you are distributing via the Sharpie-Libs-PdCursesMod nuget package.

(See https://github.com/Bill-Gray/PDCursesMod/blob/master/curses.h and commit Bill-Gray/PDCursesMod@78658c9 for the source of the change).

…rk with current native PdCursesMod libraries
pavkam
pavkam previously approved these changes Sep 26, 2025

@pavkam pavkam left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is correct as I've no way of testing this ATM. I don't remember if we have WinARM builds for this library but this might break those old versions (low interest there so not a problem for now)

@pavkam
pavkam requested a review from Copilot September 26, 2025 14:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the native function reference for the endwin function to align with the most recent version of PDCursesMod, changing from version 4302 to 4400 naming convention.

Key Changes:

  • Updates delegate name from endwin_w32_4302 to endwin_w32_4400 in the function map
  • Updates corresponding function resolver call to use the new delegate name

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
PdCursesMod32FunctionMap.cs Updates delegate declaration to match PDCursesMod version 4400
PdCursesMod32Backend.cs Updates function resolver call to reference the new delegate name

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pavkam

pavkam commented Sep 26, 2025

Copy link
Copy Markdown
Owner

Build seems to fail for some reason

@jordan-hemming

Copy link
Copy Markdown
Contributor Author

That's embarrassing. I forgot to add the the necessary changes to the Tests project to use the new function name. Sorry about that.

@pavkam
pavkam merged commit 75ab5d1 into pavkam:main Sep 26, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants