Use resolve_all on PdfFont widths and bbox#273
Merged
tataganesh merged 3 commits intopdfminer:developfrom Oct 12, 2019
igormp:develop
Merged
Use resolve_all on PdfFont widths and bbox#273tataganesh merged 3 commits intopdfminer:developfrom igormp:develop
tataganesh merged 3 commits intopdfminer:developfrom
igormp:develop
Conversation
Contributor
Author
|
Travis failed on the check for python 3 due to the missing fixes found in #274. I'll try to rebase it once the PR gets accepted |
pietermarsman
approved these changes
Jul 27, 2019
Member
pietermarsman
left a comment
pietermarsman
left a comment
There was a problem hiding this comment.
Looking good and harmless
fakabbir
approved these changes
Aug 15, 2019
Contributor
fakabbir
left a comment
fakabbir
left a comment
There was a problem hiding this comment.
Looks good, Could be merged.
Contributor
Author
|
Looks like there was a silly merge conflict, just solved it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #268, I'm recreating the PR from @shenker.
Fixes #268