chore: improve test coverage - #3828
Conversation
Signed-off-by: Frost Ming <me@frostming.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 699371dcb1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "*/pdm/cli/commands/search.py", | ||
| "*/pdm/pep582/sitecustomize.py", | ||
| "*/pdm/models/search.py", |
There was a problem hiding this comment.
Keep the search modules in coverage accounting
Removing both search modules from coverage, while also marking PyPIRepository.search() as uncovered, causes the 84% coverage gate to ignore this still-callable code entirely. In particular, tests/cli/test_search.py already exercises pdm.cli.commands.search, but those tests will no longer contribute coverage or detect a future loss of execution; regressions in SearchResultParser and repository search can similarly accumulate without affecting CI. Keep these modules measured and add focused tests for the remaining paths instead of excluding them wholesale.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3828 +/- ##
==========================================
+ Coverage 86.43% 88.16% +1.72%
==========================================
Files 121 121
Lines 13232 13221 -11
Branches 2247 2246 -1
==========================================
+ Hits 11437 11656 +219
+ Misses 1182 982 -200
+ Partials 613 583 -30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…pository Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming me@frostming.com
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.