Conversation
Drops the legacy XML site-catalog and text transformation-catalog backends, converters, parsers, and schemas now that YAML is the only supported catalog format. Refs #2235
TransformationCatalog.impl.YAML#insert(TransformationCatalogEntry, boolean) decomposed the incoming entry into individual fields and rebuilt it via addTCEntry(), silently dropping the bypass staging flag since that method's parameter list doesn't carry it. This went unnoticed because the embedded/temp-file transformation catalog fallback used the Text backend (already fixed for this via a clone-based insert), until #2235 switches that fallback to the YAML backend now that Text is being removed, exposing the latent bug and breaking test/core/043-integrity-bypass-staging-b. Mirrors Text's clone-based insert so the entry's attributes, including bypass, are preserved. Refs #2235 Refs #2238
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YAML.java's transformation-cataloginsert(), exposed by this cleanup's switch of the embedded/inline transformation-catalog fallback from the Text to the YAML backend: it decomposed entries viaaddTCEntry(...)and silently dropped thebypass_stagingflag. Now inserts a clone of the entry directly (matching the pattern already used byText.java), preserving all fields including bypass staging.testInsertPreservesBypassStaging) that fails against the pre-fix code and passes with the fix.CI note
e2e was run against the pre-fix commit and passed except for known environment-flaky tests (
031-montage-jdbcrc-sqliteOSPool execute-node transfer flakes, unrelated to this diff — same signature seen intermittently onmain). The e2e run against the fix commit was manually canceled since it was re-running the same pre-existing flakes, not anything related to this change.Closes #2235
Closes #2238