Open
Conversation
peggyrayzis
requested changes
Aug 10, 2017
Owner
peggyrayzis
left a comment
peggyrayzis
left a comment
There was a problem hiding this comment.
Hi there! Thanks for your contribution. There are a couple things that need to happen before I can merge your PR. 😀
- Please reformat your commit msgs and PR titles to Conventional Changelog Standard. Please check the contributing file for examples.
- The docs you're pointing to are for Android. Please change them to iOS (if applicable) in both
templates/modules&templates/combined. - Please update snapshot tests with
npm run test:updatewhen you're finished.
Please feel free to ask questions if any of the above is unclear. Thanks!
| // The bridge eventDispatcher is used to send events from native to JS env | ||
| // No documentation yet on DeviceEventEmitter: https://github.com/facebook/react-native/issues/2819 | ||
| // Documentation on DeviceEventEmitter: | ||
| // https://facebook.github.io/react-native/docs/native-modules-android.html#sending-events-to-javascript |
Owner
There was a problem hiding this comment.
This is pointing to the Android documentation instead of iOS.
peggyrayzis
requested changes
Aug 10, 2017
Owner
peggyrayzis
left a comment
peggyrayzis
left a comment
There was a problem hiding this comment.
Thanks! I still need you to implement the feedback from my previous review of this PR (items 1-3) before I can merge. If you have any questions, please let me know.
| // The bridge eventDispatcher is used to send events from native to JS env | ||
| // No documentation yet on DeviceEventEmitter: https://github.com/facebook/react-native/issues/2819 | ||
| // Documentation on DeviceEventEmitter: | ||
| // https://facebook.github.io/react-native/docs/native-modules-ios.html#sending-events-to-javascript |
Owner
There was a problem hiding this comment.
Thanks for making this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue mentioned in this template is now closed.
It was solved by this commit and is available in the docs.
Thanks.