[Hotfix] Invalid Semver Error#37
Conversation
refactor: make sure rnVersion is properly formatted for conditional
|
@peggyrayzis I believe there should be some test for this but I am thinking of a proper approach. If you have any input let me know! |
refactor: move semver check into file-operations.js test: update test for version check and update snapshot
test: add kotlin test for github RN version
|
@dlowder-salesforce I've added your Github version PR to this PR as best I could. One thing that was confusing was that in your PR you used the |
|
@jarretmoses that's weird, I don't remember hitting an issue with setting version to |
|
@dlowder-salesforce any luck with that |
What: Solving issue #36
Why: This change fixes an issue where the React Native version wasn't in a correct format for
compare-versionspackage (ie^0.49.3vs0.49.3).How:
package.jsonsemver.cleanChecklist: