Fix for CurseForge Generic egg#92
Open
aloshTM wants to merge 7 commits into
Open
Conversation
rmartinoscar
reviewed
Sep 2, 2025
rmartinoscar
reviewed
Sep 2, 2025
rmartinoscar
reviewed
Sep 2, 2025
rmartinoscar
reviewed
Sep 2, 2025
rmartinoscar
requested changes
Sep 2, 2025
rmartinoscar
left a comment
Contributor
There was a problem hiding this comment.
Overall i don't see this fixing anything.
If SERVER_MEMORY doesn't cut it then you didn't set server's resources properly.
Co-authored-by: MartinOscar <40749467+rmartinoscar@users.noreply.github.com>
Co-authored-by: MartinOscar <40749467+rmartinoscar@users.noreply.github.com>
Co-authored-by: MartinOscar <40749467+rmartinoscar@users.noreply.github.com>
Author
|
I see the issue now. |
Author
QuintenQVD0
requested changes
Dec 14, 2025
DaNussi
reviewed
Dec 19, 2025
Co-authored-by: DaNussi <107034782+DaNussi@users.noreply.github.com>
Contributor
|
I successfully testet the egg with the following settings:
|
7 tasks
DaNussi
reviewed
Dec 23, 2025
Co-authored-by: DaNussi <107034782+DaNussi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR proposes a change to fix CurseForge Generic servers from not starting. It attempts to grab an Egg Variable from when the server was getting setup, however there is no prompt for it. That's it.
This PR just adds an Egg Variable so the server can startup properly.
Note: The default set is 4096 MB or 4 GB, and it is required. This does also change SERVER_MEMORY into just MEMORY as Pelican does not like it for whatever reason.
Checklist for all submissions