Skip to content

Fix for CurseForge Generic egg#92

Open
aloshTM wants to merge 7 commits into
pelican-eggs:mainfrom
aloshTM:aloshTM-patch-1
Open

Fix for CurseForge Generic egg#92
aloshTM wants to merge 7 commits into
pelican-eggs:mainfrom
aloshTM:aloshTM-patch-1

Conversation

@aloshTM

@aloshTM aloshTM commented Sep 2, 2025

Copy link
Copy Markdown

Description

This PR proposes a change to fix CurseForge Generic servers from not starting. It attempts to grab an Egg Variable from when the server was getting setup, however there is no prompt for it. That's it.
This PR just adds an Egg Variable so the server can startup properly.
Note: The default set is 4096 MB or 4 GB, and it is required. This does also change SERVER_MEMORY into just MEMORY as Pelican does not like it for whatever reason.

Checklist for all submissions

  • [ X] Have you followed the guidelines in our Contributing document?
  • [X ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [X ] Have you tested and reviewed your changes with confidence that everything works?
  • [X ] Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • [X ] You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • [X ] The egg was exported from the panel

Comment thread java/curseforge/egg-curse-forge-generic.json Outdated
Comment thread java/curseforge/egg-curse-forge-generic.json Outdated
Comment thread java/curseforge/egg-curse-forge-generic.json
Comment thread java/curseforge/egg-curse-forge-generic.json Outdated

@rmartinoscar rmartinoscar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall i don't see this fixing anything.
If SERVER_MEMORY doesn't cut it then you didn't set server's resources properly.

aloshTM and others added 3 commits September 2, 2025 16:31
Co-authored-by: MartinOscar <40749467+rmartinoscar@users.noreply.github.com>
Co-authored-by: MartinOscar <40749467+rmartinoscar@users.noreply.github.com>
Co-authored-by: MartinOscar <40749467+rmartinoscar@users.noreply.github.com>
@aloshTM

aloshTM commented Sep 3, 2025

Copy link
Copy Markdown
Author

I see the issue now.
Setting the memory to unlimited when making a server during the Enviroment Configuarion doesn't set an arbitary max memory, instead it doesn't pass one, which is why it interperts it as 0
Instead, it should pass the -XX:MaxRAMPercentage=100 arguement to allow the server to grow to 100% usage if needed

@aloshTM

aloshTM commented Sep 3, 2025

Copy link
Copy Markdown
Author

This is what other eggs do, (Forge Minecraft as an example) regardless if you wanted to set the memory or not

image

This isn't really beneficial for the end user and isn't even supported on older versions of Java, so this is a very minor fix
Instead, if it is Java 21 the user can pass it themselves or add some special checks for it, however out of the scope for me

Comment thread java/curseforge/egg-curse-forge-generic.json
Comment thread java/curseforge/egg-curse-forge-generic.json Outdated
Co-authored-by: DaNussi <107034782+DaNussi@users.noreply.github.com>
@DaNussi

DaNussi commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

I successfully testet the egg with the following settings:

  • Modpack File ID 520914
  • Modpack Project ID latest
  • Allocated Memory 4096
  • Memory Limited 10Gb
  • Image ghcr.io/parkervcp/yolks:java_17

@aloshTM aloshTM requested a review from DaNussi December 23, 2025 00:35
Comment thread java/curseforge/egg-curse-forge-generic.json Outdated
aloshTM and others added 2 commits June 28, 2026 18:17
Co-authored-by: DaNussi <107034782+DaNussi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants