Skip to content

Add repository hardening files - #14

Merged
vnovitskyi merged 2 commits into
mainfrom
vn/add-repository-hardening
Apr 28, 2026
Merged

Add repository hardening files#14
vnovitskyi merged 2 commits into
mainfrom
vn/add-repository-hardening

Conversation

@vnovitskyi

@vnovitskyi vnovitskyi commented Apr 27, 2026

Copy link
Copy Markdown

Why do we need this?

As requested by AppSec team, this PR adds repository hardening to make the ofx gem compliant with Pennylane's security standards:

  • CODEOWNERS file — requires review from @pennylane-hq/transactions-hub, recommends @pennylane-hq/security
  • Pre-commit system — rubocop autocorrect, DO NOT COMMIT check, SSH key passphrase enforcement, trailing whitespace, actionlint
  • CI checks — GitHub Actions replacing the existing Travis CI config, with test matrix across Ruby 3.0–3.3+head and a CI Summary job
  • RuboCop configuration — aligned with Pennylane standards
  • Gemfile — adds rubocop, rubocop-performance, rubocop-rspec to dev dependencies

Notion:
https://www.notion.so/scribetech/ofx-442326442d614106b53c13eaa0610faf
https://www.notion.so/scribetech/Repositories-hardening-1cfc3cfcebe842bc88c3ac4fae4a0506

@vnovitskyi
vnovitskyi force-pushed the vn/add-repository-hardening branch from c329439 to 3d3ffb4 Compare April 27, 2026 06:42
@vnovitskyi
vnovitskyi force-pushed the vn/add-repository-hardening branch from 8bec663 to 7f0b00e Compare April 27, 2026 06:53
@vnovitskyi
vnovitskyi marked this pull request as ready for review April 27, 2026 07:25
@vnovitskyi
vnovitskyi requested a review from victorps-pl April 27, 2026 07:26
@vnovitskyi
vnovitskyi merged commit 7e2ac49 into main Apr 28, 2026
6 checks passed
@vnovitskyi
vnovitskyi deleted the vn/add-repository-hardening branch April 28, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants