Conversation
The tests flakiness was caused by several reasons: - tests didn't wait while Grafana inside PMM Server is fully up and running after all initializations and migrations - not all tests were idempotent - api-tests/server/settings tests update PMM Server configuration that triggers Grafana restart -> other tests fail while Grafata is unavailable. Improvements: - Added test for RTA Mongodb Agent. - api-tests/server/settings has been separated from the rest of tests and is running at the end to avoid impact on the rest of tests - Make almost all tests running in parallel -> speedup test execution - Reworked Makefile - now there are targets to prepare and run tests. reworked Makefile
maxkondr
requested review from
JiriCtvrtka and
ademidoff
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5299 +/- ##
==========================================
+ Coverage 41.49% 42.14% +0.64%
==========================================
Files 410 410
Lines 41992 41992
==========================================
+ Hits 17424 17696 +272
+ Misses 22814 22512 -302
- Partials 1754 1784 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ademidoff
reviewed
Apr 28, 2026
| InstanceID: "d752f1a9-31c9-4b8c-bb2d-d26bc000009", | ||
| NodeModel: "some-model", | ||
| Address: "some.example.rds", | ||
| Address: "some.example-1.rds", |
Member
There was a problem hiding this comment.
How come this field now takes a different value? Was it a buggy test?
Comment on lines
+9
to
+11
| ENV GONOPROXY='github.com/percona,github.com/Percona-Lab' | ||
| ENV GONOSUMDB='github.com/percona,github.com/Percona-Lab' | ||
| ENV GOPRIVATE='github.com/percona,github.com/Percona-Lab' |
Member
There was a problem hiding this comment.
Do we need all of these? It worked without it before, looks like bloat.
|
|
||
| help: ## Show available targets | ||
| @echo "Available targets: $(TARGETS)" | ||
| @grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf " \033[36m%-20s\033[0m %s\n", $$1, $$2}' |
Member
There was a problem hiding this comment.
Let's leave out colors please, don't work well in all environments, especially in the logs (not human-readable).
|
|
||
| test-report: test ## Run tests and generate JUnit report | ||
| cat $(CURDIR)/$(TEST_OUTPUT_PREFIX)-*.txt | $(BIN_DIR)/go-junit-report > $(REPORT_OUT) | ||
| @echo "✅ Report is generated: $(REPORT_OUT)." |
Member
There was a problem hiding this comment.
Suggested change
| @echo "✅ Report is generated: $(REPORT_OUT)." | |
| @echo "✅ Report generated: $(REPORT_OUT)." |
Just to make it consistent with the rest.
|
|
||
| 1. Run PMM Server. This can be done by running `make env-up` in the root (`pmm`) directory. | ||
| 2. Replace `$PMM_SERVER_URL` with a URL in format `http://USERNAME:PASSWORD@HOST`. For local development it's usually `http://admin:admin@127.0.0.1`. | ||
| 2. Replace `$PMM_SERVER_URL` with a URL in format `https://USERNAME:PASSWORD@HOST`. For local development it's usually `http://admin:admin@127.0.0.1`. |
Member
There was a problem hiding this comment.
Suggested change
| 2. Replace `$PMM_SERVER_URL` with a URL in format `https://USERNAME:PASSWORD@HOST`. For local development it's usually `http://admin:admin@127.0.0.1`. | |
| 2. Replace `$PMM_SERVER_URL` with a URL in format `https://USERNAME:PASSWORD@HOST`. For local development it's usually `https://admin:admin@127.0.0.1`. |
I think we don't really want to test http.
|
|
||
| Precompile tests using the following command: | ||
| ``` | ||
| make -j4 init |
Member
There was a problem hiding this comment.
-j4 should probably be part of the target so the user doesn't have to remember the syntax.
Member
|
@maxkondr The trouble is that the snooze tests are not passing. PTAL |
Contributor
Author
Now passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-7
Link to the Feature Build: Percona-Lab/pmm-submodules#4329
The tests flakiness was caused by several reasons:
Improvements:
Closes #2342.