PMM-14748: remove "browser" timezone from dashboards#5301
PMM-14748: remove "browser" timezone from dashboards#5301fabio-silva wants to merge 2 commits intov3from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5301 +/- ##
==========================================
+ Coverage 41.49% 41.51% +0.01%
==========================================
Files 410 540 +130
Lines 41992 44339 +2347
Branches 0 584 +584
==========================================
+ Hits 17424 18406 +982
- Misses 22814 24114 +1300
- Partials 1754 1819 +65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Removes explicit Grafana dashboard timezone setting of "browser" so dashboards rely on the default/org timezone behavior instead.
Changes:
- Update the dashboard cleanup script to write an empty timezone value instead of
"browser". - Replace
"timezone": "browser"with"timezone": ""across the remaining affected dashboards (Valkey, PostgreSQL, OS, MySQL, MongoDB, Experimental, and QAN).
Reviewed changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dashboards/misc/cleanup-dash.py | Aligns the cleanup script’s timezone normalization with the repo’s standard (empty string). |
| dashboards/dashboards/Valkey/Valkey_Slowlog.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/Valkey/Valkey_Replication.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/Valkey/Valkey_PersistenceDetails.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/Valkey/Valkey_Overview.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/Valkey/Valkey_Network.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/Valkey/Valkey_Memory.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/Valkey/Valkey_Load.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/Valkey/Valkey_CommandDetails.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/Valkey/Valkey_ClusterDetails.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/Valkey/Valkey_Clients.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/Query Analytics/pmm-qan.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/PostgreSQL/PostgreSQL_Top_Queries.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/PostgreSQL/PostgreSQL_Replication_Overview.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/PostgreSQL/PostgreSQL_Patroni_Details.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/PostgreSQL/PostgreSQL_Overview_Extended.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/PostgreSQL/PostgreSQL_Instances_Overview.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/PostgreSQL/PostgreSQL_Instance_Summary.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/PostgreSQL/PostgreSQL_Checkpoints_Buffers_WAL_Usage.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/OS/Node_Summary.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/OS/Disk_Details.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/MySQL/MySQL_Replication_Summary.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/MongoDB/MongoDB_Router_Summary.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/MongoDB/MongoDB_ReplSet_Summary.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/MongoDB/MongoDB_Oplog_Details.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/MongoDB/MongoDB_Instances_Overview.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/MongoDB/MongoDB_Instance_Summary.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/MongoDB/MongoDB_InMemory_Details.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/MongoDB/MongoDB_Collections_Overview.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/MongoDB/MongoDB_Cluster_Summary.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/MongoDB/MongoDB_Backup_Details.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/Experimental/Environments_Overview.json | Removes "browser" timezone from the dashboard metadata. |
| dashboards/dashboards/Experimental/DB_Cluster_Summary.json | Removes "browser" timezone from the dashboard metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@fabio-silva we also need to update the dashboard guide - https://www.notion.so/percona/Dashboards-Grafana-dashboard-development-rules-b2c36a37e0594eea8b4156413ed4e2d1 |
Thanks! Updated rule 9 to leave timezone empty for consistency |
PMM-14748