bugfix: stream cosocket getsslctx() bound to wrong FFI symbol#1
Open
perfgao wants to merge 1 commit into
Open
Conversation
The stream branch in lib/resty/core/socket.lua bound ngx_lua_ffi_socket_getsslctx to ngx_stream_lua_ffi_socket_tcp_get_ssl_pointer (a copy/paste of the getsslpointer block above). As a result, stream cosocket:getsslctx() returned an SSL* while callers used it as SSL_CTX*, leading to undefined behavior. Bind to ngx_stream_lua_ffi_socket_tcp_get_ssl_ctx instead, matching the http branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
lib/resty/core/socket.lua, the stream branch bindsngx_lua_ffi_socket_getsslctxtongx_stream_lua_ffi_socket_tcp_get_ssl_pointer— a copy/paste from thegetsslpointerblock above. Compare http branch at lines 103-104, which correctly uses_get_ssl_ctx.Impact
stream
cosocket:getsslctx()actually returnsSSL *while callers treat it asSSL_CTX *→ UB / potential segfault.Fix
Bind to
ngx_stream_lua_ffi_socket_tcp_get_ssl_ctx(declaration already in the streamffi.cdef).Upstream PR: openresty#530