Skip to content

Now checks if entries array has items #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EliMoshkovich merged 12 commits into from
Nov 4, 2025
Merged

Now checks if entries array has items #74

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
879da94
Now checks if entries array has items
EliMoshkovich Nov 3, 2025
b82a8f2
Fix helm lint
EliMoshkovich Nov 4, 2025
c207d07
Upgrade CI Helm version and revert unnecessary template changes
EliMoshkovich Nov 4, 2025
de3c3e5
Upgrade k3d-action and k3s version to fix CI cluster startup
EliMoshkovich Nov 4, 2025
363a212
Fix k3d config schema for v1alpha4 compatibility
EliMoshkovich Nov 4, 2025
7eae41f
Fix e2e test service names to match Helm naming convention
EliMoshkovich Nov 4, 2025
d48794f
Fix e2e test to use external curl pod instead of exec into client
EliMoshkovich Nov 4, 2025
137f1eb
Fix bash test syntax by quoting command substitutions
EliMoshkovich Nov 4, 2025
b555e69
Improve e2e test debugging with echo statements
EliMoshkovich Nov 4, 2025
d24cbd9
Fix e2e test to match actual OPA response format
EliMoshkovich Nov 4, 2025
0489093
Fix e2e test empty data check to match OPA behavior
EliMoshkovich Nov 4, 2025
75300ad
Filter out kubectl pod deletion messages from curl output
EliMoshkovich Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/deployment-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ spec:
- name: OPAL_SERVER_URL
value: {{ printf "http://%s:%v" (include "opal.serverName" .) .Values.server.port | quote }}
{{- end}}
{{- if not (or (.Values.server.dataConfigSources.external_source_url) (.Values.server.dataConfigSources.config) (hasKey .Values.client.extraEnv "OPAL_DATA_UPDATER_ENABLED") ) }}
{{- if not (or (.Values.server.dataConfigSources.external_source_url) (and .Values.server.dataConfigSources.config .Values.server.dataConfigSources.config.entries) (hasKey .Values.client.extraEnv "OPAL_DATA_UPDATER_ENABLED") ) }}
- name: OPAL_DATA_UPDATER_ENABLED
value: "False"
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion templates/deployment-server.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ spec:
{{- end }}
- name: UVICORN_NUM_WORKERS
value: {{ .Values.server.uvicornWorkers | quote }}
{{- if or .Values.server.dataConfigSources.config .Values.server.dataConfigSources.external_source_url }}
{{- if or .Values.server.dataConfigSources.external_source_url (and .Values.server.dataConfigSources.config .Values.server.dataConfigSources.config.entries) }}
- name: OPAL_DATA_CONFIG_SOURCES
value: {{ .Values.server.dataConfigSources | toRawJson | squote }}
{{- end}}
Expand Down
Loading