Shahar/per 12589 golang sdk getusersfortenant - #68
Merged
Conversation
🏗️ Architecture The implementation leverages the existing generated OpenAPI client: The OpenAPI method ListTenantUsers was already generated from the API spec Our implementation is a simple, clean wrapper that: Handles pagination validation Manages context and configuration Provides proper error handling and logging Returns the data in the expected format (users.GetData()) 🧪 Testing ✅ Compilation: All code compiles without errors ✅ Integration Test: Added to existing test suite ✅ Pattern Compliance: Follows exact patterns used throughout the codebase 📚 API Endpoint The feature calls the Permit.io REST API: Apply to tenants.go users Response: Paginated list of users within the specified tenant, including user details like key, email, first name, last name, and attributes. The implementation is minimal, clean, and follows all the best practices established in the codebase! 🎉
RazcoDev
reviewed
Jul 2, 2025
RazcoDev
reviewed
Jul 2, 2025
Deleted detailed assertions and edge case tests for tenant user listing and pagination from the integration test. This streamlines the test suite by focusing on core permission checks and reduces coupling to user creation logic.
RazcoDev
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get Tenant's Users