Fix benchmark script GC memory leak causing OOM (exit code 137)#1053
Merged
Conversation
The GCSuite class was disabling garbage collection during benchmark runs but never re-enabling it, causing unbounded memory growth with large payloads and many iterations. This triggered the OOM killer (SIGKILL = exit code 137). Add GC.enable calls to warmup_stats and add_report callbacks to ensure GC is re-enabled between benchmark phases while still keeping it disabled during timing-sensitive measurements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GCSuite class was disabling garbage collection during benchmark runs but never re-enabling it, causing unbounded memory growth with large payloads and many iterations. This triggered the OOM killer (SIGKILL = exit code 137).
Add GC.enable calls to warmup_stats and add_report callbacks to ensure GC is re-enabled between benchmark phases while still keeping it disabled during timing-sensitive measurements.