fix: avoid touching remote ~/.ssh when starting sshd#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #7
背景
sshpod は sshd 起動時にリモート側の ~/.ssh/environment を作成し、PermitUserEnvironment yes を有効化していました。
この前提は、ホームが NFS 上にある環境や ~/.ssh が外部管理されている環境では問題が起きます。
今回の再現環境では /root が NFS で、/root/.ssh は /ssh_config への symlink でした。
そのため mkdir -p "$USER_HOME/.ssh" が File exists で失敗し、root での初回接続時に sshd 起動前に abort していました。
変更内容
影響
確認