Clang-tidy google-readability-braces-around-statements and other enhancements - #2958
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
update test is passing: |
| ELSE | ||
| throws_ok('errorTestManyWeights', | ||
| 'XX000', | ||
| 'Graph Condition Failed: Graph should have atmost two distinct non-negative edge costs! If there are exactly two distinct edge costs, one of them must equal zero!', |
There was a problem hiding this comment.
The problem for update test is that I fixed spelling, atmost -> at most so for library versions before 4.0.0 spelling is still wrong.
|
|
||
| SELECT throws_ok('errorTestManyWeights', | ||
| SELECT | ||
| CASE WHEN min_lib_version('4.0.0') THEN |
There was a problem hiding this comment.
This checks for the library used
Changes proposed in this pull request:
Files rename:
cpp_common/basePath_SSEC.hpp->cpp_common/path.hppcpp_common/basePath_SSEC.cpp->cpp_common/path.cppClang-tidy:
While doing the fix: the static
get_routewith same code was in 4 filesget_route->get_viaRoutecpp_common/to_postgres.hppand implementation oncpp_common/to_postgres.cpp@pgRouting/admins