Skip to content

clang-tidy: fix assert.hpp cppcoreguidelines-explicit-virtual-functions #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvvergara merged 5 commits into from
Jan 3, 2026
Merged

clang-tidy: fix assert.hpp cppcoreguidelines-explicit-virtual-functions #3005

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9dd441a
Add cppcoreguidelines-explicit-virtual-functions
bhavishy2801 Dec 19, 2025
ff405fc
fix warnings in assert.hpp
bhavishy2801 Dec 26, 2025
9d78e06
fix warnings in assert.hpp
bhavishy2801 Dec 27, 2025
9e0588c
restore .clang-tidy to upstream version
bhavishy2801 Dec 31, 2025
95ee8ff
restore .clang-tidy to upstream develop version
bhavishy2801 Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ Checks: >
cppcoreguidelines-avoid-capturing-lambda-coroutines,
cppcoreguidelines-avoid-goto,
cppcoreguidelines-avoid-non-const-global-variables,
cppcoreguidelines-avoid-reference-coroutine-parameters
cppcoreguidelines-avoid-reference-coroutine-parameters,
cppcoreguidelines-explicit-virtual-functions
Comment thread
cvvergara marked this conversation as resolved.
Outdated

WarningsAsErrors: ''
HeaderFilterRegex: './include'
FormatStyle: none
InheritParentConfig: true
InheritParentConfig: true
Comment thread
cvvergara marked this conversation as resolved.
Outdated
4 changes: 2 additions & 2 deletions include/cpp_common/assert.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,9 @@ class AssertFailedException : public std::exception {
const std::string str; ///< Holds what() we got as message

public:
virtual const char *what() const throw();
const char *what() const throw() override;
explicit AssertFailedException(std::string msg);
virtual ~AssertFailedException() throw() {}
~AssertFailedException() throw() override {}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
};

#endif // INCLUDE_CPP_COMMON_ASSERT_HPP_