clang-tidy : add cppcoreguidelines-init-variables

[Eternity0207]

Summary by CodeRabbit

• Chores
  • Updated development tool configuration for enhanced code analysis during the development process.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The .clang-tidy configuration file is updated to enable the cppcoreguidelines-init-variables static analysis check, while preserving the existing cppcoreguidelines-avoid-reference-coroutine-parameters check with proper formatting.

Changes

Cohort / File(s)	Change Summary
Clang-tidy configuration .clang-tidy	Enabled cppcoreguidelines-init-variables check in the Checks list and corrected trailing comma formatting for check separation

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A comma here, a check there,
Static analysis rules we declare,
Variables initialized, tight and neat,
Stricter checks make code complete! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding the cppcoreguidelines-init-variables check to the .clang-tidy configuration file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d76cc6 and 72aff4c.

📒 Files selected for processing (1)

• .clang-tidy

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: cvvergara
Repo: pgRouting/pgrouting PR: 2771
File: sql/common/_checkquery.sql:33-33
Timestamp: 2025-02-27T23:05:28.589Z
Learning: When reviewing PostgreSQL/pgRouting code, respect the maintainer's preference for brevity over additional comments when variable names are descriptive.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Codacy Static Code Analysis

🔇 Additional comments (2)

.clang-tidy (2)

9-9: LGTM: Proper list formatting.

The trailing comma correctly separates list items in preparation for the new check.

---

10-10: Verify the impact on the existing codebase.

Adding cppcoreguidelines-init-variables enforces initialization of local variables (integers, booleans, floats, doubles, and pointers) at declaration. This check examines whether local variables are declared without an initial value, which may lead to unexpected behavior if there is a code path that reads the variable before assigning it. The check may flag numerous existing uninitialized variables.

Run this check on representative source files to preview the warnings it will generate before fully enabling it project-wide.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cvvergara]

I compiled locally using:

CXX=clang++ CC=clang cmake  -DUSE_CLANG_TIDY=ON  -DBUILD_HTML=OFF -DPOSTGRESQL_BIN=${PGBIN} ..

and these are some of the many warnings I get that are not fixed,

[ 20%] Building CXX object src/trsp/CMakeFiles/trsp.dir/trsp_driver.cpp.o
/home/vicky/pgrouting/pgrouting/cvvergara/include/contraction/contractionGraph.hpp:185:15: warning: variable 'inserted' is not initialized [cppcoreguidelines-init-variables]
  185 |          bool inserted;
      |               ^       
      |                        = false
/home/vicky/pgrouting/pgrouting/cvvergara/include/contraction/contractionGraph.hpp:398:14: warning: variable 'found_e' is not initialized [cppcoreguidelines-init-variables]
  398 |         bool found_e;
      |              ^      
      |                      = false
/home/vicky/pgrouting/pgrouting/cvvergara/include/contraction/contractionGraph.hpp:426:18: warning: variable 'inserted' is not initialized [cppcoreguidelines-init-variables]
  426 |             bool inserted;
      |                  ^       
      |                           = false
/home/vicky/pgrouting/pgrouting/cvvergara/include/contraction/contractionGraph.hpp:437:17: warning: variable 'p_max' is not initialized [cppcoreguidelines-init-variables]
  437 |         int64_t p_max;
      |                 ^    
      |                       = 0
/home/vicky/pgrouting/pgrouting/cvvergara/include/contraction/contractionGraph.hpp:439:14: warning: variable 'found_e' is not initialized [cppcoreguidelines-init-variables]
  439 |         bool found_e;
      |              ^      
      |                      = false

Please fix
the files under contraction directory

[Eternity0207]

Since this cppcoreguidelines, was used multiple times, I am completing the task-4 using another cppcoreguidline, kindly review the other PR,
#3016