Check cppcoreguidelines-special-member-functions and fix code

.clang-tidy

@@ -1,15 +1,29 @@
 Checks: >
-    google-*,
-    -google-readability-casting,
-    clang-analyzer-*,
-    clang-diagnostic-*,
-    cppcoreguidelines-avoid-capturing-lambda-coroutines,
-    cppcoreguidelines-avoid-goto,
-    cppcoreguidelines-avoid-non-const-global-variables,
-    cppcoreguidelines-avoid-reference-coroutine-parameters,
-    cppcoreguidelines-init-variables
+  google-*,
+  -google-readability-casting,
+  clang-analyzer-*,
+  clang-diagnostic-*,
+  cppcoreguidelines-avoid-capturing-lambda-coroutines,
+  cppcoreguidelines-avoid-goto,
+  cppcoreguidelines-avoid-non-const-global-variables,
+  cppcoreguidelines-avoid-reference-coroutine-parameters,
+  cppcoreguidelines-init-variables,
+  cppcoreguidelines-special-member-functions
+
+CheckOptions:
+  - key: cppcoreguidelines-special-member-functions.DefaultConstructor
+    value: true
+  - key: cppcoreguidelines-special-member-functions.CopyConstructor
+    value: true
+  - key: cppcoreguidelines-special-member-functions.CopyAssignment
+    value: true
+  - key: cppcoreguidelines-special-member-functions.MoveConstructor
+    value: true
+  - key: cppcoreguidelines-special-member-functions.MoveAssignment
+    value: true
 
 WarningsAsErrors: ''
 HeaderFilterRegex: './include'
-FormatStyle:     none
+FormatStyle: none
 InheritParentConfig: true
+

include/cpp_common/assert.hpp

@@ -145,6 +145,11 @@ class AssertFailedException : public std::exception {
  public:
      const char *what() const noexcept override;
      explicit AssertFailedException(std::string msg);
+    AssertFailedException(const AssertFailedException&) = default;
+    AssertFailedException(AssertFailedException&&) noexcept = default;
+    AssertFailedException& operator=(const AssertFailedException&) = delete;
+    AssertFailedException& operator=(AssertFailedException&&) noexcept = delete;
+
      ~AssertFailedException() noexcept override {}
 };
 

include/cpp_common/basic_vertex.hpp

@@ -42,6 +42,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 namespace pgrouting {
 
 class Basic_vertex {
+
  public:
      Basic_vertex() :
          id(0) {}
@@ -52,7 +53,9 @@ class Basic_vertex {
          id(_id) {}
 
      Basic_vertex& operator=(const Basic_vertex&) = default;
-
+    ~Basic_vertex() = default;
+     Basic_vertex(Basic_vertex&&) = default;
+     Basic_vertex& operator=(Basic_vertex&&) = default;
      Basic_vertex(const Edge_t &other, bool is_source) :
          id(is_source? other.source : other.target) {}
 

include/cpp_common/messages.hpp

@@ -35,11 +35,16 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 namespace pgrouting {
 
+
 class Pgr_messages {
+
  public:
-    Pgr_messages() = default;
-    Pgr_messages(const Pgr_messages&) = delete;
-    Pgr_messages& operator=(const Pgr_messages&) = delete;
+  Pgr_messages() = default;
+  Pgr_messages(const Pgr_messages&) = delete;
+  Pgr_messages& operator=(const Pgr_messages&) = delete;
+  ~Pgr_messages() = default;
+  Pgr_messages(Pgr_messages&&) = delete;
+  Pgr_messages& operator=(Pgr_messages&&) = delete;
 
     /*! @brief get_log
      *

include/vrp/fleet.hpp

@@ -62,7 +62,10 @@ class Fleet {
      /*!@}*/
 
      Fleet& operator=(const Fleet &fleet);
+     Fleet(Fleet&&) noexcept = default;
+     Fleet& operator=(Fleet&&) noexcept = default;
 
+     ~Fleet() = default;
      void set_compatibles(const PD_Orders &orders);
 
      bool is_fleet_ok() const;

include/vrp/pd_problem.hpp

@@ -39,17 +39,24 @@ namespace vrp {
 class Pgr_pickDeliver;
 
 class PD_problem {
+
  public:
-    /** @brief Initializing the problem pointer */
-    explicit PD_problem(Pgr_pickDeliver* p_problem);
+  /** @brief Initializing the problem pointer */
+  explicit PD_problem(Pgr_pickDeliver* p_problem);
 
-    /** @brief Not wllowing to copy the problem */
-    PD_problem(const PD_problem &problem) = delete;
+  /** @brief Not allowing copy */
+  PD_problem(const PD_problem&) = delete;
+  PD_problem& operator=(const PD_problem&) = delete;
 
-    /** @brief Not allowing initialization without information */
-    PD_problem() = delete;
-};
+  /** @brief Not allowing move */
+  PD_problem(PD_problem&&) = delete;
+  PD_problem& operator=(PD_problem&&) = delete;
 
+  /** @brief Not allowing default construction */
+  PD_problem() = delete;
+
+  ~PD_problem() = default;
+};
 }  //  namespace vrp
 }  //  namespace pgrouting