Bioconductor downloads - #361
Open
AKlebus wants to merge 6 commits into
Open
Conversation
emilliman5
self-requested a review
March 21, 2025 16:07
emilliman5
requested changes
Mar 21, 2025
| #' @importFrom cranlogs cran_downloads | ||
| #' @keywords internal | ||
| pkg_ref_cache.downloads.pkg_ref <- function(x, ..., n = 365) { | ||
| downloads <- cran_downloads(x$name, from = Sys.Date() - n, to = Sys.Date()) |
Collaborator
There was a problem hiding this comment.
I don't think there is any need to dispatch a download method for pkg_ref, in fact we should return NA "by default" to account for sources that do not have download stats (e.g. source packages)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #360
Bioconductor downloads
This PR adds functionality for caching downloads for packages on Bioconductor. Previously, this downloads functionality only attempted to get package downloads from CRAN, meaning popular Bioconductor packages were judged as if they had 0 downloads. With this change, assessments of Bioconductor package downloads should be more informative.
Background
Hi! My team and I at Novartis wanted to contribute this functionality to riskmetric as it is something we have implemented for an internal tool. I personally am quite new to software engineering, and this is my first PR for an open source project, so I would really appreciate any thoughts or feedback on how we can better integrate this functionality. Looking forward to the discussion!