Skip to content

feat: add xsltproc to embedded-cpp flavor#1380

Open
André Jordan (andjordan) wants to merge 5 commits into
mainfrom
feature/xsltproc
Open

feat: add xsltproc to embedded-cpp flavor#1380
André Jordan (andjordan) wants to merge 5 commits into
mainfrom
feature/xsltproc

Conversation

@andjordan

@andjordan André Jordan (andjordan) commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

🚀 Hey, I have created a Pull Request

Description of changes

This PR re-introduces xsltproc into the embedded-cpp devcontainer flavor so XML→C++ transformations used by downstream repos can run inside the container image.

Changes:

  • Add xsltproc to the embedded-cpp tool inventory.
  • Introduce a pinned apt requirement for xsltproc for the embedded-cpp flavor.
  • Update the shared cpp Dockerfile to conditionally install embedded-cpp apt requirements when BUILD_EMBEDDED_FLAVOR=true.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM
  • I understand the image size delta and agree the functionality justifies it

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 23 0 0 0.27s
✅ DOCKERFILE hadolint 4 0 0 0.31s
✅ JSON npm-package-json-lint yes no no 0.61s
✅ JSON prettier 45 6 0 0 1.25s
✅ JSON v8r 45 0 0 19.75s
✅ MARKDOWN markdownlint 13 0 0 0 1.35s
✅ MARKDOWN markdown-table-formatter 13 0 0 0 0.32s
✅ REPOSITORY betterleaks yes no no 1.44s
✅ REPOSITORY checkov yes no no 34.12s
✅ REPOSITORY gitleaks yes no no 1.24s
✅ REPOSITORY git_diff yes no no 0.03s
✅ REPOSITORY grype yes no no 76.41s
⚠️ REPOSITORY osv-scanner yes 1 no 0.72s
✅ REPOSITORY secretlint yes no no 2.55s
✅ REPOSITORY syft yes no no 3.14s
✅ REPOSITORY trivy yes no no 14.04s
✅ REPOSITORY trivy-sbom yes no no 0.38s
✅ REPOSITORY trufflehog yes no no 8.09s
⚠️ SPELL lychee 117 1 0 11.1s
✅ YAML prettier 36 0 0 0 1.55s
✅ YAML v8r 36 0 0 17.77s
✅ YAML yamllint 36 0 0 1.64s

Detailed Issues

⚠️ SPELL / lychee - 1 error
📝 Summary
---------------------
🔍 Total..........154
🔗 Unique.........126
✅ Successful.....148
⏳ Timeouts.........0
🔀 Redirected......19
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1
⛔ Unsupported......1

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads (at 38:7) | Rejected status code: 403 Forbidden

Hint: Followed 19 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`
⚠️ REPOSITORY / osv-scanner - 1 error
Scanning dir .
Starting filesystem walk for root: /
Scanned .devcontainer/cpp/requirements.txt file and found 20 packages
Scanned .devcontainer/docs/requirements.txt file and found 14 packages
Scanned test/embedded-rust/workspace/cortex-m/Cargo.lock file and found 20 packages
Scanned test/embedded-rust/workspace/cortex-mf/Cargo.lock file and found 20 packages
Scanned test/rust/workspace/cargo/Cargo.lock file and found 1 package
Scanned test/rust/workspace/clippy/Cargo.lock file and found 1 package
Scanned test/rust/workspace/test/Cargo.lock file and found 1 package
Scanned package-lock.json file and found 73 packages
End status: 104 dirs visited, 340 inodes visited, 8 Extract calls, 46.529228ms elapsed, 46.529379ms wall time

Total 2 packages affected by 2 known vulnerabilities (0 Critical, 0 High, 0 Medium, 0 Low, 2 Unknown) from 1 ecosystem.
0 vulnerabilities can be fixed.

+-----------------------------------+------+-----------+------------+---------+---------------+---------------------------------------------------+
| OSV URL                           | CVSS | ECOSYSTEM | PACKAGE    | VERSION | FIXED VERSION | SOURCE                                            |
+-----------------------------------+------+-----------+------------+---------+---------------+---------------------------------------------------+
| https://osv.dev/RUSTSEC-2026-0110 |      | crates.io | bare-metal | 0.2.5   | --            | test/embedded-rust/workspace/cortex-m/Cargo.lock  |
| https://osv.dev/RUSTSEC-2026-0110 |      | crates.io | bare-metal | 0.2.5   | --            | test/embedded-rust/workspace/cortex-mf/Cargo.lock |
+-----------------------------------+------+-----------+------------+---------+---------------+---------------------------------------------------+

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_GRYPE,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Test Results

 25 files  ±0   25 suites  ±0   17m 28s ⏱️ -42s
 48 tests ±0   48 ✅ ±0  0 💤 ±0  0 ❌ ±0 
209 runs  +8  209 ✅ +8  0 💤 ±0  0 ❌ ±0 

Results for commit c48fca5. ± Comparison against base commit 0f31ce4.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edgeghcr.io/philips-software/amp-devcontainer-base:pr-1380

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 75.35 MB 75.35 MB +17 B (+0%) 🔼
linux/arm64 73.43 MB 73.43 MB +327 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-docs:edgeghcr.io/philips-software/amp-devcontainer-docs:pr-1380

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 200.14 MB 200.14 MB 187 B (0%) 🔽
linux/arm64 196.35 MB 196.35 MB +225 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1380

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 406.07 MB 406.07 MB +274 B (+0%) 🔼
linux/arm64 357.64 MB 357.64 MB +408 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-embedded-rust:edgeghcr.io/philips-software/amp-devcontainer-embedded-rust:pr-1380

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 468.96 MB 468.96 MB 136 B (0%) 🔽
linux/arm64 419.9 MB 419.9 MB +217 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1380

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 372.12 MB 372.13 MB +819 B (+0%) 🔼
linux/arm64 352.26 MB 352.26 MB +166 B (+0%) 🔼

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-embedded-cpp:edgeghcr.io/philips-software/amp-devcontainer-embedded-cpp:pr-1380

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 560.5 MB 560.6 MB +105.51 kB (+0.02%) 🔼
linux/arm64 538.95 MB 539.04 MB +95.52 kB (+0.02%) 🔼

@rjaegers Ron (rjaegers) changed the title feat: xsltproc in embedded cpp flavor feat: add xsltproc to embedded-cpp flavor Jul 23, 2026
@andjordan
André Jordan (andjordan) marked this pull request as ready for review July 23, 2026 11:46
@andjordan
André Jordan (andjordan) requested a review from a team as a code owner July 23, 2026 11:46
Copilot AI review requested due to automatic review settings July 23, 2026 11:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-introduces xsltproc into the embedded-cpp devcontainer flavor so XML→C++ transformations used by downstream repos can run inside the container image.

Changes:

  • Add xsltproc to the embedded-cpp tool inventory.
  • Introduce a pinned apt requirement for xsltproc for the embedded-cpp flavor.
  • Update the shared cpp Dockerfile to conditionally install embedded-cpp apt requirements when BUILD_EMBEDDED_FLAVOR=true.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.devcontainer/embedded-cpp/tool-inventory.json Adds xsltproc to the embedded-cpp declared tool set.
.devcontainer/embedded-cpp/apt-requirements-embedded-cpp.json Pins the xsltproc apt package version for embedded-cpp builds.
.devcontainer/cpp/Dockerfile Conditionally installs embedded-cpp apt requirements during embedded flavor builds.

Comment thread .devcontainer/cpp/Dockerfile
@sonarqubecloud

Copy link
Copy Markdown

@rjaegers
Ron (rjaegers) deployed to acceptance-testing July 23, 2026 13:36 — with GitHub Actions Active
@rjaegers
Ron (rjaegers) added this pull request to the merge queue Jul 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants