chore: really_assert if 'SynchronousFlashRegion' is defined correctly#1266
Merged
heinwessels (heinwessels-philips) merged 2 commits intoJul 10, 2026
Merged
Conversation
Contributor
Dependency ReviewThe following issues were found:
Snapshot WarningsConsider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. License Issuesexternal/crypto/tiny-aes128/CMakeLists.txt
external/args/CMakeLists.txt
external/segger_rtt/CMakeLists.txt
osal/freertos/CMakeLists.txt
lwip/lwip/CMakeLists.txt
infra/syntax/CMakeLists.txt
external/crypto/micro-ecc/CMakeLists.txt
external/protobuf/CMakeLists.txt
osal/threadx/CMakeLists.txt
cmake/emil_test_helpers.cmake
external/crypto/mbedtls/CMakeLists.txt
OpenSSF ScorecardScorecard details
Scanned Files
|
Copilot started reviewing on behalf of
heinwessels (heinwessels-philips)
July 9, 2026 12:07
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens services::SynchronousFlashRegion construction-time validation by switching a sector-range precondition from assert (compiled out in release) to really_assert (active in release), ensuring misconfigured regions fail fast in production builds.
Changes:
- Use
really_assertinSynchronousFlashRegionconstructor to validate region bounds in release builds. - Add
infra.utiltoservices.synchronous_utillink libraries to supportReallyAssert.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/synchronous_util/SynchronousFlashRegion.cpp | Adds ReallyAssert include and replaces constructor assert with really_assert. |
| services/synchronous_util/CMakeLists.txt | Links infra.util so ReallyAssert is available to the library. |
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 11 | 0 | 0 | 0.28s | |
| ✅ ACTION | zizmor | 11 | 0 | 0 | 0 | 3.1s |
| ✅ CPP | clang-format | 1096 | 8 | 0 | 0 | 9.98s |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.05s | |
| ✅ JSON | jsonlint | 7 | 0 | 0 | 0.32s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0 | 0.59s |
| markdownlint | 8 | 0 | 5 | 0 | 1.29s | |
| ✅ MARKDOWN | markdown-table-formatter | 8 | 0 | 0 | 0 | 0.29s |
| ✅ REPOSITORY | checkov | yes | no | no | 33.58s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.07s | |
| ✅ REPOSITORY | grype | yes | no | no | 56.2s | |
| ✅ REPOSITORY | ls-lint | yes | no | no | 0.01s | |
| osv-scanner | yes | 1 | no | 0.67s | ||
| ✅ REPOSITORY | secretlint | yes | no | no | 16.85s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.52s | |
| ✅ REPOSITORY | trivy | yes | no | no | 21.64s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.31s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 13.28s | |
| lychee | 140 | 1 | 0 | 106.32s | ||
| prettier | 21 | 1 | 1 | 0 | 0.63s | |
| ✅ YAML | v8r | 21 | 0 | 0 | 9.33s | |
| ✅ YAML | yamllint | 21 | 0 | 0 | 0.72s |
Detailed Issues
⚠️ SPELL / lychee - 1 error
📝 Summary
---------------------
🔍 Total..........697
🔗 Unique.........661
✅ Successful.....691
⏳ Timeouts.........0
🔀 Redirected.....310
👻 Excluded.........5
❓ Unknown..........0
🚫 Errors...........1
⛔ Unsupported......1
Errors in external/protoc/CMakeLists.txt
[404] https://github.com/protocolbuffers/protobuf/releases/download/v$%7Bprotobuf_tag%7D/protoc-$%7Bprotobuf_version%7D-$%7Bos_postfix%7D.zip (at 18:13) | Rejected status code: 404 Not Found
Hint: Followed 310 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`
⚠️ MARKDOWN / markdownlint - 5 errors
.github/instructions/microtest.instructions.md:7 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Google Test Suite Coding Ru..."]
external/crypto/tiny-aes128/README.md:1 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "### Tiny AES128 in C"]
external/crypto/tiny-aes128/README.md:29 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
external/crypto/tiny-aes128/README.md:39 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
external/crypto/tiny-aes128/README.md:49 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
⚠️ REPOSITORY / osv-scanner - 1 error
Scanning dir .
Starting filesystem walk for root: /
Scanned external/segger_rtt file and found 0 packages
Scanned external/args file and found 0 packages
Scanned external/protobuf file and found 0 packages
Scanned external/protoc file and found 0 packages
Scanned external/crypto file and found 0 packages
End status: 155 dirs visited, 1617 inodes visited, 5 Extract calls, 548.704572ms elapsed, 548.705003ms wall time
No package sources found, --help for usage information.
⚠️ YAML / prettier - 1 error
[error] Explicitly specified pattern "documents/modules/ROOT/examples/clangformat.yaml" is a symbolic link.
.clusterfuzzlite/project.yaml 27ms (unchanged)
.github/dependabot.yml 15ms (unchanged)
.github/workflows/ci.yml 85ms (unchanged)
.github/workflows/dependency-scanner.yml 7ms (unchanged)
.github/workflows/documentation.yml 9ms (unchanged)
.github/workflows/fuzzing-batch.yml 5ms (unchanged)
.github/workflows/fuzzing-cron.yml 6ms (unchanged)
.github/workflows/fuzzing-pr.yml 6ms (unchanged)
.github/workflows/linting-formatting.yml 11ms (unchanged)
.github/workflows/release-please.yml 11ms (unchanged)
.github/workflows/security.yml 6ms (unchanged)
.github/workflows/static-analysis.yml 9ms (unchanged)
.github/workflows/validate-pr.yml 14ms (unchanged)
.ls-lint.yml 3ms
.mega-linter.yml 4ms (unchanged)
antora-playbook-branch.yml 3ms (unchanged)
antora-playbook-site.yml 3ms (unchanged)
documents/antora.yml 2ms (unchanged)
documents/supplemental-ui/ui.yml 2ms (unchanged)
mull.yml 1ms (unchanged)
Notices
📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,ACTION_ZIZMOR,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
Show us your support by starring ⭐ the repository
Copilot started reviewing on behalf of
heinwessels (heinwessels-philips)
July 9, 2026 12:32
View session
|
Richard Peters (richardapeters)
approved these changes
Jul 10, 2026
heinwessels (heinwessels-philips)
deleted the
feature/really-assert-sync-flash-region-size
branch
July 10, 2026 19:16
Contributor
|
heinwessels (@heinwessels-philips) This codebase uses a lot |
Contributor
Author
I agree that it should be changed, but a big change like this would first need to be discussed with internally first to weigh the pros and cons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this was a regular
assert, which was missed for a month already because nobody uses debug builds.