fix: increase host network event dispatcher capacity to 1024#1277
Merged
Gabriel Santos (gabrielsantosphilips) merged 1 commit intoJul 20, 2026
Conversation
The BSD/Windows network event dispatcher schedules one action per ready socket event. When the host consumer is briefly stalled while many events arrive at once, the fixed 50-slot ring overflows and trips the scheduling assert in EventDispatcherWithWeakPtr. Raise the capacity to 1024 so such bursts are absorbed; host builds have ample memory for the larger ring.
Gabriel Santos (gabrielsantosphilips)
requested a review
from a team
as a code owner
July 20, 2026 12:45
Contributor
Dependency ReviewThe following issues were found:
Snapshot WarningsConsider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. License Issuesosal/threadx/CMakeLists.txt
cmake/emil_test_helpers.cmake
external/segger_rtt/CMakeLists.txt
external/crypto/tiny-aes128/CMakeLists.txt
external/args/CMakeLists.txt
external/crypto/micro-ecc/CMakeLists.txt
external/crypto/mbedtls/CMakeLists.txt
osal/freertos/CMakeLists.txt
external/protobuf/CMakeLists.txt
lwip/lwip/CMakeLists.txt
infra/syntax/CMakeLists.txt
OpenSSF ScorecardScorecard details
Scanned Files
|
Copilot started reviewing on behalf of
Gabriel Santos (gabrielsantosphilips)
July 20, 2026 12:46
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases the scheduling ring capacity used by the host (BSD/Windows) network event dispatcher to better absorb bursts of socket readiness events when the consumer is briefly stalled, avoiding overflow asserts in infra::EventDispatcherWithWeakPtr.
Changes:
- Increase
infra::EventDispatcherWithWeakPtr::WithSizecapacity from 50 to 1024 for the Windows host network event dispatcher. - Increase
infra::EventDispatcherWithWeakPtr::WithSizecapacity from 50 to 1024 for the BSD/Unix host network event dispatcher.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/network_instantiations/EventDispatcherWithNetworkWin.hpp | Enlarges the underlying weak-ptr dispatcher scheduled-action ring for Windows host networking. |
| services/network_instantiations/EventDispatcherWithNetworkBsd.hpp | Enlarges the underlying weak-ptr dispatcher scheduled-action ring for BSD/Unix host networking. |
Richard Peters (richardapeters)
approved these changes
Jul 20, 2026
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 11 | 0 | 0 | 0.29s | |
| ✅ ACTION | zizmor | 11 | 0 | 0 | 0 | 2.81s |
| ✅ CPP | clang-format | 1098 | 8 | 0 | 0 | 10.0s |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.07s | |
| ✅ JSON | jsonlint | 7 | 0 | 0 | 0.35s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0 | 0.56s |
| markdownlint | 8 | 0 | 5 | 0 | 1.36s | |
| ✅ MARKDOWN | markdown-table-formatter | 8 | 0 | 0 | 0 | 0.36s |
| ✅ REPOSITORY | checkov | yes | no | no | 36.89s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.06s | |
| ✅ REPOSITORY | grype | yes | no | no | 65.98s | |
| ✅ REPOSITORY | ls-lint | yes | no | no | 0.02s | |
| osv-scanner | yes | 1 | no | 0.59s | ||
| ✅ REPOSITORY | secretlint | yes | no | no | 18.96s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.9s | |
| ✅ REPOSITORY | trivy | yes | no | no | 19.65s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 1.28s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 13.01s | |
| lychee | 140 | 1 | 0 | 117.96s | ||
| prettier | 21 | 1 | 1 | 0 | 0.67s | |
| ✅ YAML | v8r | 21 | 0 | 0 | 11.1s | |
| ✅ YAML | yamllint | 21 | 0 | 0 | 0.69s |
Detailed Issues
⚠️ SPELL / lychee - 1 error
📝 Summary
---------------------
🔍 Total..........697
🔗 Unique.........661
✅ Successful.....691
⏳ Timeouts.........0
🔀 Redirected.....309
👻 Excluded.........5
❓ Unknown..........0
🚫 Errors...........1
⛔ Unsupported......1
Errors in external/protoc/CMakeLists.txt
[404] https://github.com/protocolbuffers/protobuf/releases/download/v$%7Bprotobuf_tag%7D/protoc-$%7Bprotobuf_version%7D-$%7Bos_postfix%7D.zip (at 18:13) | Rejected status code: 404 Not Found
Hint: Followed 309 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`
⚠️ MARKDOWN / markdownlint - 5 errors
.github/instructions/microtest.instructions.md:7 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Google Test Suite Coding Ru..."]
external/crypto/tiny-aes128/README.md:1 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "### Tiny AES128 in C"]
external/crypto/tiny-aes128/README.md:29 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
external/crypto/tiny-aes128/README.md:39 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
external/crypto/tiny-aes128/README.md:49 error MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
⚠️ REPOSITORY / osv-scanner - 1 error
Scanning dir .
Starting filesystem walk for root: /
Scanned external/crypto file and found 0 packages
Scanned external/segger_rtt file and found 0 packages
Scanned external/args file and found 0 packages
Scanned external/protobuf file and found 0 packages
Scanned external/protoc file and found 0 packages
End status: 155 dirs visited, 1618 inodes visited, 5 Extract calls, 466.520283ms elapsed, 466.520614ms wall time
No package sources found, --help for usage information.
⚠️ YAML / prettier - 1 error
[error] Explicitly specified pattern "documents/modules/ROOT/examples/clangformat.yaml" is a symbolic link.
.clusterfuzzlite/project.yaml 45ms (unchanged)
.github/dependabot.yml 20ms (unchanged)
.github/workflows/ci.yml 76ms (unchanged)
.github/workflows/dependency-scanner.yml 8ms (unchanged)
.github/workflows/documentation.yml 12ms (unchanged)
.github/workflows/fuzzing-batch.yml 6ms (unchanged)
.github/workflows/fuzzing-cron.yml 7ms (unchanged)
.github/workflows/fuzzing-pr.yml 7ms (unchanged)
.github/workflows/linting-formatting.yml 11ms (unchanged)
.github/workflows/release-please.yml 9ms (unchanged)
.github/workflows/security.yml 10ms (unchanged)
.github/workflows/static-analysis.yml 10ms (unchanged)
.github/workflows/validate-pr.yml 15ms (unchanged)
.ls-lint.yml 3ms
.mega-linter.yml 4ms (unchanged)
antora-playbook-branch.yml 2ms (unchanged)
antora-playbook-site.yml 3ms (unchanged)
documents/antora.yml 3ms (unchanged)
documents/supplemental-ui/ui.yml 2ms (unchanged)
mull.yml 2ms (unchanged)
Notices
📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,ACTION_ZIZMOR,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
Show us your support by starring ⭐ the repository
|
heinwessels (heinwessels-philips)
approved these changes
Jul 20, 2026
Gabriel Santos (gabrielsantosphilips)
merged commit Jul 20, 2026
0af913e
into
main
39 of 40 checks passed
Gabriel Santos (gabrielsantosphilips)
deleted the
feature/increase-network-event-dispatcher-capacity
branch
July 20, 2026 14:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BSD/Windows network event dispatcher schedules one action per ready socket event. When the host consumer is briefly stalled while many events arrive at once, the fixed 50-slot ring overflows and trips the scheduling assert in EventDispatcherWithWeakPtr. Raise the capacity to 1024 so such bursts are absorbed; host builds have ample memory for the larger ring.