fix(agentgateway-bootstrap): restore get RBAC verb on agentgatewayparameters#307
Merged
Andy Lo-A-Foe (loafoe) merged 1 commit intoJul 23, 2026
Conversation
…ameters A prior review flagged the get verb as unused (the script only ever patches the CR) and it was dropped for stricter least-privilege. Live deployment revealed this was wrong: kubectl patch fetches the current object before sending the merge patch, so patch-only RBAC is rejected: Error from server (Forbidden): agentgatewayparameters.agentgateway.dev "agentgateway-gw-params" is forbidden: User "system:serviceaccount: agentgateway:agentgateway-bootstrap-postgres-wire" cannot get resource "agentgatewayparameters" in API group "agentgateway.dev" in the namespace "agentgateway" Restoring get alongside patch.
Andy Lo-A-Foe (loafoe)
deleted the
fix/agentgateway-bootstrap-postgres-wire-rbac-get
branch
July 23, 2026 14:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A prior review round flagged
getonagentgatewayparametersas unused RBAC scope(the script only ever
patches the CR) and it was dropped in #306. Deploying to areal cluster revealed this was incorrect:
kubectl patchfetches the current objectbefore sending the merge patch, so
patch-only RBAC is rejected:Restores
getalongsidepatch.Test plan
verbs: ["get", "patch"]on theagentgatewayparametersrulekubectl patchsucceeds with this RBAC