test: Enable MSTest Analyzers - #858
Merged
Merged
Conversation
|
Brian Collamore (bcollamore)
requested review from
Copilot and
Ynse Hoornenborg (ynsehoornenborg)
August 2, 2025 23:37
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables MSTest Analyzers to improve test code quality and consistency. The changes make helper classes internal/sealed to reduce their public API surface and replace a generic exception assertion with a more specific one.
- Updated class visibility modifiers from public to internal sealed for test helper classes
- Replaced Assert.ThrowsExceptionAsync with Assert.ThrowsExactlyAsync for more precise exception testing
- Enabled MSTest analyzer rules in .editorconfig with error severity (except MSTEST0019 which is disabled)
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Philips.CodeAnalysis.Test/Helpers/TestTextLoader.cs | Changed class visibility from public to internal sealed |
| Philips.CodeAnalysis.Test/Helpers/TestDiagnosticProvider.cs | Changed class visibility from public to internal sealed |
| Philips.CodeAnalysis.Test/Helpers/TestDefinitions.cs | Changed class visibility from public to internal sealed |
| Philips.CodeAnalysis.Test/Helpers/TestAdditionalFile.cs | Changed class visibility from public to internal sealed |
| Philips.CodeAnalysis.Test/Helpers/AssertCodeHelper.cs | Changed class visibility from public to internal sealed |
| Philips.CodeAnalysis.Test/DuplicateCode/AvoidDuplicateCodeAnalyzerTest.cs | Changed nested class visibility from public to internal sealed |
| Philips.CodeAnalysis.Test/Common/SingleDiagnosticAnalyzerSyntaxKindTest.cs | Replaced Assert.ThrowsExceptionAsync with Assert.ThrowsExactlyAsync |
| Philips.CodeAnalysis.Test/Common/AllowedSymbolsTestAnalyzer.cs | Changed class visibility from public to internal sealed |
| .editorconfig | Added MSTest analyzer rules configuration |
Brian Collamore (bcollamore)
enabled auto-merge
August 2, 2025 23:38
Ynse Hoornenborg (ynsehoornenborg)
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.