[FEATURE] Add :nbsp: text role for non-breaking spaces#1280
Merged
Conversation
Implements the :nbsp: text role which produces a non-breaking space ( ). This provides an explicit alternative to the ~ syntax (e.g., a~b) for inserting non-breaking spaces. Usage: :nbsp:`ignored content` The content is ignored; the role simply produces a non-breaking space. This completes existing infrastructure (WhitespaceInlineNode and nbsp.html.twig template) that was added but never wired up.
Remove SKIP marker now that the :nbsp: text role is implemented.
Contributor
Author
Alternative: Remove the test instead?After implementing this, I'm questioning whether the The a~b → a bThe a :nbsp:`x` b → a bOptions
Question for maintainersThe test was imported from doctrine/rst-parser (commit If the |
jaapio
requested changes
Jan 3, 2026
jaapio
left a comment
Member
There was a problem hiding this comment.
Thanks for this PR, this test slipped through our reviews.
jaapio
approved these changes
Jan 4, 2026
Member
|
Thanks for this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
:nbsp:text role which produces a non-breaking space ( ). This provides an explicit alternative to the~syntax (e.g.,a~b) for inserting non-breaking spaces.Usage:
The content inside the role is ignored; the role simply produces a non-breaking space.
Background
:nbsp:was imported from doctrine/rst-parser in commit77e1f40cWhitespaceInlineNodeandnbsp.html.twigtemplate) already existedSKIPChanges
NbspTextRoleclass that returnsWhitespaceInlineNodeSKIPmarker from the functional testTest plan
nbsp-role- now passes